Skip to content

fix: Add title for footer links that open in a new tab #153 #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 13, 2023
Merged

fix: Add title for footer links that open in a new tab #153 #162

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abd3c24
fix: Add title for footer links that open in a new tab #153
pprev94 Aug 9, 2023
51aaca9
fix: [ouvre une nouvelle fenêtre] should be localized as well
pprev94 Aug 10, 2023
3207b5f
Update src/Footer.tsx
pprev94 Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,7 @@ export const Footer = memo(
)}
target="_blank"
href={`https://${domain}`}
title={`${domain} - ${t("open new window")}`}
>
{domain}
</a>
Expand Down Expand Up @@ -502,12 +503,17 @@ const { useTranslation, addFooterTranslations } = createComponentI18nApi({
"license mention": (p: { licenseUrl: string }) => (
<>
Sauf mention contraire, tous les contenus de ce site sont sous{" "}
<a href={p.licenseUrl} target="_blank">
<a
href={p.licenseUrl}
target="_blank"
title="licence etalab-2.0 - ouvre une nouvelle fenêtre"
>
licence etalab-2.0
</a>
</>
),
"our partners": "Nos partenaires"
"our partners": "Nos partenaires",
"open new window": "ouvre une nouvelle fenêtre"
/* spell-checker: enable */
}
});
Expand All @@ -524,11 +530,16 @@ addFooterTranslations({
"license mention": p => (
<>
Unless stated otherwise, all content of this website is under the{" "}
<a href={p.licenseUrl} target="_blank">
<a
href={p.licenseUrl}
target="_blank"
title="etalab-2.0 license - open a new window"
>
etalab-2.0 license
</a>
</>
)
),
"open new window": "open new window"
}
});

Expand Down