feat: add Card component #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 16, 2022 09:50
Signed-off-by: Julien Bouquillon <julien.bouquillon@sg.social.gouv.fr>
Signed-off-by: Julien Bouquillon <julien.bouquillon@sg.social.gouv.fr>
garronej
reviewed
Dec 21, 2022
src/Card.tsx
Outdated
| horizontal?: boolean; | ||
| size?: "small" | "medium" | "large"; // only affect the text | ||
| enlargeLink?: boolean; // make the whole card clickable | ||
| iconId?: FrIconClassName | RiIconClassName; // only needed when enlargeMode=true |
Collaborator
There was a problem hiding this comment.
What is enlargeMode? Wouldn't it make sence to express this in the type def?
Collaborator
Author
There was a problem hiding this comment.
enlargeMode makes the whole card clickable; what do you mean by express this in the type def? ?
Collaborator
Author
There was a problem hiding this comment.
my bad, its not enlargeMode but enlargeLink
Collaborator
There was a problem hiding this comment.
enlargeMode makes the whole card clickable; what do you mean by express this in the type def? ?
type EnlargedLink = {
enlargeLink: true;
iconId?: FrIconClassName | RiIconClassName;
};
type NotEnlargedLink = {
enlargeLink?: false;
iconId?: never;
}
type Props = .... & (EnlargedLink | NotEnlargedLink);
Collaborator
Author
There was a problem hiding this comment.
Yay makes sense thanks
Co-authored-by: Joseph Garrone <joseph.garrone.gj@gmail.com> Signed-off-by: Julien Bouquillon <contact@revolunet.com>
Co-authored-by: Joseph Garrone <joseph.garrone.gj@gmail.com> Signed-off-by: Julien Bouquillon <contact@revolunet.com>
Co-authored-by: Joseph Garrone <joseph.garrone.gj@gmail.com> Signed-off-by: Julien Bouquillon <contact@revolunet.com>
Signed-off-by: Julien Bouquillon <julien.bouquillon@sg.social.gouv.fr>
Collaborator
|
Thank you for the adjustments! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add Card component