Fix the CollectionWrapper case #36

Merged
merged 10 commits into from Nov 23, 2012

Conversation

Projects
None yet
2 participants
@arsduo
Contributor

arsduo commented Nov 22, 2012

I have to admit I'm not clear on the purpose of this lint -- is there something undesirable about non-Array instance variables?

Either way, I realized it was only allowing one array assignment -- an object that wrapped multiple arrays would fail. Of course, I realize now that that may be desirable -- in which case, feel free to reject this.

Note: this depends on #35.

@oriolgual

This comment has been minimized.

Show comment Hide comment
@oriolgual

oriolgual Nov 23, 2012

Member

Yeah, I guess a collection wrapper could handle multiple arrays. Works for me :)

Member

oriolgual commented Nov 23, 2012

Yeah, I guess a collection wrapper could handle multiple arrays. Works for me :)

oriolgual added a commit that referenced this pull request Nov 23, 2012

Merge pull request #36 from arsduo/fixes/arrays
Fix the CollectionWrapper case

@oriolgual oriolgual merged commit 1d0949b into codegram:master Nov 23, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment