Skip to content

Combine tags on feature with tags on scenario to find if a scenario should run #107

Merged
merged 3 commits into from May 22, 2012

3 participants

@JonathanTron

Needs code in this pull-request: codegram/gherkin-ruby#15

@josepjaume
Codegram member

This needs codegram/gherkin-ruby#15 as well

Maybe we should add some documentation to explain this behavior. Still, +1!

Thanks for your awesome work, Jonathan! :)

@JonathanTron JonathanTron and 1 other commented on an outdated diff May 21, 2012
lib/spinach/parser/visitor.rb
@@ -38,6 +38,7 @@ def visit(ast)
def visit_Feature(node)
@feature.name = node.name
node.background.accept(self) if node.background
+ node.tags.each { |tag| tag.accept(self) }
@JonathanTron
JonathanTron added a note May 21, 2012

If I'm making this one optional (if node.respond_to?(:tags)), it would work even without the mentioned commit in gherkin-ruby.
What do you think ?

@josepjaume
Codegram member
josepjaume added a note May 21, 2012

We've released gherkin-ruby 0.2.0 with your addition so this won't be needed.

Let's see what does the rest of the people think of your PR and then we can merge it

@JonathanTron
JonathanTron added a note May 21, 2012

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@oriolgual
Codegram member

It would be nice if you could also add a note to the README so people know they can use it :)

@JonathanTron

I added a new Tags section, with some information about tags and how you can use them.

@josepjaume
Codegram member

Oooh, many thanks!! This was hugely needed :)

@josepjaume josepjaume merged commit 1dfcd87 into codegram:master May 22, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.