Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test newer Ruby versions #214

Merged
merged 13 commits into from
Apr 5, 2020
Merged

Test newer Ruby versions #214

merged 13 commits into from
Apr 5, 2020

Conversation

mrcasals
Copy link
Contributor

@mrcasals mrcasals commented Apr 3, 2020 •
edited
Loading

This PR tests spinach against the newest Ruby versions.

@mrcasals
Copy link
Contributor Author

mrcasals commented Apr 3, 2020

@ywen hi! Would you mind reviewing this PR, please? It tests spinach against the newest Ruby versions, and drops supports for EOL versions.

Thank you!

@ywen
Copy link
Collaborator

ywen commented Apr 3, 2020

It shows this?

Screen Shot 2020-04-03 at 12 57 54 PM

@mrcasals
Copy link
Contributor Author

mrcasals commented Apr 4, 2020

@ywen this PR also ports the tests from TravisCI to GitHub Actions, to try it out. I can bring that back if you want me to, but so far I'm pretty happy with GitHub Actions. TravisCI took a while to start the jobs, for some reason, that's why I switched!

@ywen
Copy link
Collaborator

ywen commented Apr 4, 2020

@ywen this PR also ports the tests from TravisCI to GitHub Actions, to try it out. I can bring that back if you want me to, but so far I'm pretty happy with GitHub Actions. TravisCI took a while to start the jobs, for some reason, that's why I switched!

No I think github action seems nice. Please get rid of travisCI hook. Thank you!

@mrcasals
Copy link
Contributor Author

mrcasals commented Apr 5, 2020

@ywen done!

ywen
ywen approved these changes Apr 5, 2020
View reviewed changes
Copy link
Collaborator

@ywen ywen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywen ywen merged commit 6ebed33 into master Apr 5, 2020
@ywen ywen deleted the chore/test-new-ruby-versions branch April 5, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywen ywen ywen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrcasals @ywen