New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter on Internationalization and Localization #641

Merged
merged 7 commits into from Nov 14, 2016

Conversation

Projects
None yet
7 participants
@igorsantos07
Contributor

igorsantos07 commented Feb 16, 2016

Inclusion of material regarding pure i18n implementation, related to Gettext and Poedit.

Refs #623.

@igorsantos07

This comment has been minimized.

Show comment
Hide comment
@igorsantos07

igorsantos07 Feb 16, 2016

Contributor

I'm currently working on with LingoHub to get their approval for quotations and reference linking, as their article is a great resource for this subject but is copyrighted. Thus, some sections (such as key naming) were skipped until a decision is made by them.

Contributor

igorsantos07 commented Feb 16, 2016

I'm currently working on with LingoHub to get their approval for quotations and reference linking, as their article is a great resource for this subject but is copyrighted. Thus, some sections (such as key naming) were skipped until a decision is made by them.

@igorsantos07

This comment has been minimized.

Show comment
Hide comment
@igorsantos07

igorsantos07 Feb 16, 2016

Contributor

Thanks @drbyte, that's what happens when you write text after midnight :D
Fixed locally.

Contributor

igorsantos07 commented Feb 16, 2016

Thanks @drbyte, that's what happens when you write text after midnight :D
Fixed locally.

igorsantos07 added some commits Feb 15, 2016

Adding basic explanation on i18n and section TODOs
- what's i18n, l10n and pluralization forms for
- common methods of implementation
- added the rest of the sub-sections, with TODOs
i18n: review and finishing post
- part about key types has been reviewed
- included the pieces about using Poedit, caching issues and usual helper functions

@igorsantos07 igorsantos07 referenced this pull request Feb 27, 2016

Closed

i18n and l10n #623

@igorsantos07

This comment has been minimized.

Show comment
Hide comment
@igorsantos07

igorsantos07 Feb 29, 2016

Contributor

@drbyte thanks for all that effort on reviewing :)
Besides not being native, I've been writing that during late night, not the most attentive part of my day 😅

Contributor

igorsantos07 commented Feb 29, 2016

@drbyte thanks for all that effort on reviewing :)
Besides not being native, I've been writing that during late night, not the most attentive part of my day 😅

@drbyte

This comment has been minimized.

Show comment
Hide comment
@drbyte

drbyte Feb 29, 2016

Contributor

Besides not being native, I've been writing that during late night, not the most attentive part of my day

Hey, for “not being native”, your command of English is good! :)

Contributor

drbyte commented Feb 29, 2016

Besides not being native, I've been writing that during late night, not the most attentive part of my day

Hey, for “not being native”, your command of English is good! :)

@philsturgeon

This comment has been minimized.

Show comment
Hide comment
@philsturgeon

philsturgeon Feb 29, 2016

Collaborator

@drbyte You speak better English than I speak Portugese that's for sure. I've been trying to learn Spanish for a year and I'm just about good enough to get through a meal, and have a few useless bastard phrases boiled into my head like "No es un huevo, es un manzana!"

I have much respect for anyone contributing in a language other than their first. Hopefully you weren't be embarrassed somebody pointed out the typos and tweaks, it's all part of the process. :)

Collaborator

philsturgeon commented Feb 29, 2016

@drbyte You speak better English than I speak Portugese that's for sure. I've been trying to learn Spanish for a year and I'm just about good enough to get through a meal, and have a few useless bastard phrases boiled into my head like "No es un huevo, es un manzana!"

I have much respect for anyone contributing in a language other than their first. Hopefully you weren't be embarrassed somebody pointed out the typos and tweaks, it's all part of the process. :)

@drbyte

This comment has been minimized.

Show comment
Hide comment
@drbyte

drbyte Feb 29, 2016

Contributor

Agreed @philsturgeon . I've huge respect for what @igorsantos07 has contributed, particularly writing in non-native language.

And, I've learned some stuff about gettext that I didn't know before too :)

Contributor

drbyte commented Feb 29, 2016

Agreed @philsturgeon . I've huge respect for what @igorsantos07 has contributed, particularly writing in non-native language.

And, I've learned some stuff about gettext that I didn't know before too :)

@igorsantos07

This comment has been minimized.

Show comment
Hide comment
@igorsantos07

igorsantos07 Feb 29, 2016

Contributor

@drbyte that's for sure what makes me happy :D

Regarding get embarrassed, those where mostly typos and result of a lack of attention, at most. I would get if I had written uninteligible babble hahahaha

Contributor

igorsantos07 commented Feb 29, 2016

@drbyte that's for sure what makes me happy :D

Regarding get embarrassed, those where mostly typos and result of a lack of attention, at most. I would get if I had written uninteligible babble hahahaha

@igorsantos07

This comment has been minimized.

Show comment
Hide comment
@igorsantos07

igorsantos07 Apr 23, 2016

Contributor

@codeguy any news on this? :)

Contributor

igorsantos07 commented Apr 23, 2016

@codeguy any news on this? :)

@igorsantos07

This comment has been minimized.

Show comment
Hide comment
@igorsantos07

igorsantos07 Jul 18, 2016

Contributor

@codeguy was this forgotten? :(

Contributor

igorsantos07 commented Jul 18, 2016

@codeguy was this forgotten? :(

@drbyte

This comment has been minimized.

Show comment
Hide comment
@drbyte

drbyte Jul 19, 2016

Contributor

When I last reviewed it, my opinion was 👍
Hopefully it will get merged.

Contributor

drbyte commented Jul 19, 2016

When I last reviewed it, my opinion was 👍
Hopefully it will get merged.

@philsturgeon

This comment has been minimized.

Show comment
Hide comment
@philsturgeon

philsturgeon Jul 19, 2016

Collaborator

It's got a +1 from me. I threw this out on Twitter to see if there is any further feedback, and if nothing has happened in 24 hours I'll click that shiny green button.

Collaborator

philsturgeon commented Jul 19, 2016

It's got a +1 from me. I threw this out on Twitter to see if there is any further feedback, and if nothing has happened in 24 hours I'll click that shiny green button.

@codeguy

This comment has been minimized.

Show comment
Hide comment
@codeguy

codeguy Jul 19, 2016

Owner

+1 from me. @philsturgeon if this is ready to merge with no more feedback, go ahead and merge.

Owner

codeguy commented Jul 19, 2016

+1 from me. @philsturgeon if this is ready to merge with no more feedback, go ahead and merge.

@igorsantos07

This comment has been minimized.

Show comment
Hide comment
@igorsantos07

igorsantos07 Nov 13, 2016

Contributor

@codeguy, @philsturgeon: I added the forgotten suggestions and also checked the text for a couple of more subtle grammar mistakes :)

I think it's now finally ready? Almost a year taking dust, sorry for making this even longer.

Contributor

igorsantos07 commented Nov 13, 2016

@codeguy, @philsturgeon: I added the forgotten suggestions and also checked the text for a couple of more subtle grammar mistakes :)

I think it's now finally ready? Almost a year taking dust, sorry for making this even longer.

@philsturgeon philsturgeon merged commit 42fa3bf into codeguy:gh-pages Nov 14, 2016

@philsturgeon

This comment has been minimized.

Show comment
Hide comment
@philsturgeon

philsturgeon Nov 14, 2016

Collaborator

Great work @igorsantos07! Thank you for following through on the requested changes. FOSS is not always speedy, but the willingness to keep at it is appreciated.

Collaborator

philsturgeon commented Nov 14, 2016

Great work @igorsantos07! Thank you for following through on the requested changes. FOSS is not always speedy, but the willingness to keep at it is appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment