Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding JMS Resource support for Weblogic container #6

Merged
merged 3 commits into from May 6, 2015

Conversation

Projects
None yet
2 participants
@sutaakar
Copy link
Contributor

commented Apr 29, 2015

Hello,

This is my idea of how Weblogic resource configuration implementation could look. It is implemented by using dedicated configuration builder for every resource supported - so far just JMS - which is bound to specific resource in WebLogicFactoryRegistry.
Some resources have to be created before others, so they are sorted first.

What do you think about this?

@alitokmen

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2015

Hi Karel

Please check the CI, your commit is breaking the build:

Compilation failure

/home/runner/cargo/core/api/generic/src/main/java/org/codehaus/cargo/generic/configuration/builder/DefaultConfigurationBuilderFactory.java:[78,5] method does not override a method from its superclass
/home/runner/cargo/core/api/generic/src/main/java/org/codehaus/cargo/generic/configuration/builder/DefaultConfigurationBuilderFactory.java:[88,5] method does not override a method from its superclass
/home/runner/cargo/core/api/generic/src/main/java/org/codehaus/cargo/generic/configuration/builder/DefaultConfigurationBuilderFactory.java:[96,5] method does not override a method from its superclass

REMEMBER: We support JDKs as old as version 5, so you need to be mindful when coding.

Thank you

@sutaakar

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2015

Hi Ali,

Thanks for info, made update in my commit.
Build failed again, but this time there seems to be some port allocation issue in one execution.

@alitokmen

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2015

Hi Karel

Thanks for the fix, I see another one pending:

Caused by: org.apache.maven.plugin.compiler.CompilationFailureException: Compilation failure
/home/runner/cargo/core/containers/weblogic/src/main/java/org/codehaus/cargo/container/weblogic/AbstractWebLogicWlstStandaloneLocalConfiguration.java:[117,17] cannot find symbol
symbol : method sort(org.codehaus.cargo.container.weblogic.internal.configuration.util.PriorityComparator)
location: interface java.util.List<org.codehaus.cargo.container.configuration.entry.Resource>

Can you take care of that one as well? I'm sorry, but we really need to keep the Java 5 compatibility :)

Thank you

@sutaakar

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2015

Hi Ali,

Thanks for pointing it out, I had wrongly set my Eclipse project. Now code should be Java 1.5 compatible (I hope :) ).
I added also one sorting test to have at least some basic functionality check, could make other test later.

alitokmen added a commit that referenced this pull request May 6, 2015

Merge pull request #6 from sutaakar/master
Adding JMS Resource support for Weblogic container - Thanks Karel for the corrections!

@alitokmen alitokmen merged commit 0258d2e into codehaus-cargo:master May 6, 2015

1 check passed

semaphoreci The build passed on Semaphore.
Details
@alitokmen

This comment has been minimized.

Copy link
Contributor

commented May 6, 2015

Excellent, thanks Karel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.