Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed regressions: #163 and #194 #195

Merged
merged 1 commit into from Apr 16, 2022

Conversation

belingueres
Copy link
Contributor

@belingueres belingueres commented Apr 5, 2022

* codehaus-plexus#163 - new case:  Don't assume UTF8 as default, to allow parsing from String.
* codehaus-plexus#194 - Incorrect getText() after parsing the DOCDECL section.
* Added tests exercising other regressions exposed while fixing this issues.
@michael-o michael-o merged commit b99f7c0 into codehaus-plexus:master Apr 16, 2022
20 checks passed
@belingueres
Copy link
Contributor Author

belingueres commented Apr 17, 2022

@michael-o Thanks for merging this PR. Unfortunately two of the test files where commited with the wrong git core.autocrlf setting, losing the intended CRLF line endings:
src/test/resources/xml/test-entities-dos.xml
src/test/resources/xml/test-entities-in-attr-dos.xml

@michael-o
Copy link
Member

michael-o commented Apr 17, 2022

Please provide a followup PR with gitattributes for these files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants