Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Change PHP version requirement to 7.1. Fixes #847
  • Loading branch information
@lonnieezell
lonnieezell committed Dec 21, 2017
1 parent 6fb133b commit 90a604c
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion .travis.yml
View file
@@ -1,7 +1,6 @@
language: php

php:
- 7
- 7.1
- 7.2
- nightly
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Expand Up @@ -16,7 +16,7 @@
}
},
"require": {
"php": ">=7.0",
"php": ">=7.1",

This comment has been minimized.

Sign in to view

Copy link
@timothymarois

timothymarois Jan 27, 2018 •
edited

Contributor

I'd like to know why we are only supporting 7.1+, what is being used that causes 7.0 to be obsolete? I read the "go php 7.1" doc and I have yet to find the "reason" behind it. All it says is, "why not?", might as well go to 7.2 while we're at it since that was just released. Unless there is a feature in CI4 that relies on 7.1 I think this is nonsense. Please explain.

This comment has been minimized.

Sign in to view

Copy link
@timothymarois

timothymarois Jan 27, 2018

Contributor

PHP 7.0 has already given us the incredible feature upgrades that this framework relies on and supports. I would like an educated debate as to why 7.1 should be the new minimum requirement because as it stands now, I don't see any argument yet to suggest 7.1 is superior and that 7.0 is not enough to run this framework.

This comment has been minimized.

Sign in to view

Copy link
@timothymarois

timothymarois Jan 27, 2018

Contributor

The article written by Tomas has no factual evidence to support the requirement other than to "just do it". That, unfortunately, is not enough.

This comment has been minimized.

Sign in to view

Copy link
@lonnieezell

lonnieezell Jan 29, 2018

Author Member

As a community, I think the push is a fair one. PHP7.0 was a big change in the internal code and took quite a few rapid releases to become truly stable. 7.1 builds on that so is a more secure and stable platform, theoretically.

As for CI specifically - no, we don't currently use any 7.1 features, but that allows us to. Things like nullable types and HTTP/2 server push built into cURL could prove nice. Additionally, CI4 hasn't released a true Alpha version yet. With my current workload I anticipate an Alpha release not happening until early summer. Leaving a beta or RC release not happening until end of summer at the earliest. 7.0 is already receiving security patches only and will be considered end of life at the end of 2018, just shortly after CI4 is released.

This comment has been minimized.

Sign in to view

Copy link
@benedmunds

benedmunds Jan 29, 2018

Collaborator

I also agree we should go 7.1, no real concern given the release schedule of CI v PHP 7.0's EOL.

This comment has been minimized.

Sign in to view

Copy link
@jim-parry

jim-parry Jan 29, 2018

Contributor

I would be fine with a minimum version of 7.2, so that we have libsodium for encryption!
7.1 as a minimum is better than 7.0 :-/

This comment has been minimized.

Sign in to view

Copy link
@timothymarois

timothymarois Feb 9, 2018

Contributor

@lonnieezell Got it. Thanks for the clarification.
"zendframework/zend-escaper": "^2.5",
"paragonie/sodium_compat": "^1.1",
"kint-php/kint": "^2.1"
Expand Down
2 changes: 1 addition & 1 deletion user_guide_src/source/intro/requirements.rst
View file
Expand Up @@ -2,7 +2,7 @@
Server Requirements
###################

`PHP <http://php.net/>`_ version 7.0.15 or newer is required, with the *intl* extension installed.
`PHP <http://php.net/>`_ version 7.1 or newer is required, with the *intl* extension installed. [Why 7.1](https://gophp71.org/)?

A database is required for most web application programming.
Currently supported databases are:
Expand Down

0 comments on commit 90a604c

Please sign in to comment.