Skip to content

Conversation

@MGatner
Copy link
Member

@MGatner MGatner commented May 7, 2019

Description
Issue #1992 describes the scenario where an entity without every field set will cause non-null database column to error {column_name} cannot be null. This PR will create the necessary tests to catch this scenario prior to providing a fix.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner
Copy link
Member Author

MGatner commented May 7, 2019

Testing with the expected exception "worked" (I got the exception type wrong, but it still threw: https://travis-ci.org/codeigniter4/CodeIgniter4/jobs/529399940). I've removed the expectation and this should now cause a failure because the entity doesn't have every field set.

@MGatner MGatner changed the title WIP Add partial Entity save() testing Add partial Entity save() testing May 7, 2019
@MGatner
Copy link
Member Author

MGatner commented May 14, 2019

Made irrelevant by Entity refactor, #2002

@MGatner MGatner closed this May 14, 2019
@MGatner MGatner deleted the entity-partial-test branch May 14, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant