Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all language returns to single quote #2311

Merged
merged 1 commit into from Oct 10, 2019

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Oct 8, 2019

Description
lang() requires single quotes in order to parse bracketed indexes. Mostly this is all correct but there are a few files still using double quotes. This PR converts these.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@jim-parry
Copy link
Contributor

Oh crap - this is going to affect the codeigniter4/translations repo too.

@MGatner
Copy link
Member Author

MGatner commented Oct 8, 2019

You're right. It looks like the same files in each locale are using double quotes.

What are your students up to this week? :)

@jim-parry
Copy link
Contributor

They are working on localizations for the website. There, it doesn't matter about single vs double quotes, since all text gets passed through the template parser, sometimes after going through a markdown processor.

I'll raise an issue in the translations repo. At least there aren't as many translations there as for CI3!

@MGatner
Copy link
Member Author

MGatner commented Oct 8, 2019

I feel confident a little awk-foo could take care of 90% of this - it just takes me an hour to figure out the actual command to use. Posting an issue is a good idea, maybe some awkmaster will stumble along and hav pity.

@jim-parry jim-parry merged commit a63b6fa into codeigniter4:develop Oct 10, 2019
@MGatner MGatner deleted the language-quotes branch October 10, 2019 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants