Optimizations for Autoloader #4604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbalandan
force-pushed
the
autoloader-optimize
branch
from
55af775
to
6228bd3
Compare
samsonasik
reviewed
Apr 24, 2021
MGatner
reviewed
Apr 24, 2021
Comment on lines
+203
to
+205
| $file = $this->classmap[$class] ?? ''; | ||
|
|
||
| if (is_string($file) && $file !== '') |
There was a problem hiding this comment.
This seems like a whole lot of effort not to use empty().
There was a problem hiding this comment.
I'm using phpstan/phpstan-strict-rules in my workflows a lot, and one of the strict rules I'm following is the disallowance of empty() which implies loose comparison.
There was a problem hiding this comment.
Understood. I'm not against this verbose, strict approach but I personally prefer empty() when it saves multiple conditions.
MGatner
approved these changes
Apr 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimizations include:
Checklist: