Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting of value in Cookie's flag attributes #4736

Merged
merged 2 commits into from May 25, 2021
Merged

Fix setting of value in Cookie's flag attributes #4736

merged 2 commits into from May 25, 2021

Conversation

paulbalandan
Copy link
Member

Description

  • Fixes a bug in Cookie constructor where you cannot set a falsy value for HttpOnly and Secure attributes. Also removed extra code for $defaults merging.
  • Fixes some errors in the docs

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan merged commit e3d77f9 into codeigniter4:develop May 25, 2021
@paulbalandan paulbalandan deleted the cookie-bc branch May 25, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paulbalandan @MGatner