(Paging) Ensure page validity #5125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
~ get valid page after validation in pager
+ apply style
paulbalandan
requested changes
Sep 24, 2021
+ add test function for page lower/higher than available pages
|
@paulbalandan something like this ? |
mostafakhudair
suggested changes
Sep 24, 2021
|
@puschie286 Please run |
Co-authored-by: Mostafa Khudair <59371810+mostafakhudair@users.noreply.github.com>
~ cs-fix
lonnieezell
approved these changes
Oct 5, 2021
kenjis
added
the
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An invalid page lead to an exception when using the model paginate function.
page::store validates the page but it doesnt update the page used in the model.
So we need to read the page value again after calling pager::store in paginate