From db56f87527013db169bd4883d51a53df421bdf1b Mon Sep 17 00:00:00 2001 From: kenjis Date: Sun, 25 Dec 2022 09:43:00 +0900 Subject: [PATCH 1/5] docs: fix file path decoration --- user_guide_src/source/installation/upgrade_405.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/user_guide_src/source/installation/upgrade_405.rst b/user_guide_src/source/installation/upgrade_405.rst index d83f461b3218..245e443ecb65 100644 --- a/user_guide_src/source/installation/upgrade_405.rst +++ b/user_guide_src/source/installation/upgrade_405.rst @@ -16,7 +16,7 @@ Please refer to the upgrade instructions corresponding to your installation meth CodeIgniter 4.0.5 introduces a setting for the cookie SameSite attribute. Prior versions did not set this attribute at all. The default setting for cookies is now `Lax`. This will affect how cookies are handled in -cross-domain contexts and you may need to adjust this setting in your projects. Separate settings in `app/Config/App.php` +cross-domain contexts and you may need to adjust this setting in your projects. Separate settings in **app/Config/App.php** exists for Response cookies and for CSRF cookies. For additional information, see `MDN Web Docs `_. From 4582fbcee3ae47787581c26a485bdb94de716844 Mon Sep 17 00:00:00 2001 From: kenjis Date: Sun, 25 Dec 2022 09:43:30 +0900 Subject: [PATCH 2/5] docs: add () after method names --- user_guide_src/source/installation/upgrade_405.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/user_guide_src/source/installation/upgrade_405.rst b/user_guide_src/source/installation/upgrade_405.rst index 245e443ecb65..5ea329bb7ef1 100644 --- a/user_guide_src/source/installation/upgrade_405.rst +++ b/user_guide_src/source/installation/upgrade_405.rst @@ -32,8 +32,8 @@ to all classes that extend ``Message`` as well: ``Request``, ``Response`` and th Additional related deprecations from the HTTP layer: -* ``Message::isJSON``: Check the "Content-Type" header directly -* ``Request[Interface]::isValidIP``: Use the Validation class with ``valid_ip`` +* ``Message::isJSON()``: Check the "Content-Type" header directly +* ``Request[Interface]::isValidIP()``: Use the Validation class with ``valid_ip`` * ``Request[Interface]::getMethod()``: The ``$upper`` parameter will be removed, use str_to_upper() * ``Request[Trait]::$ipAddress``: This property will become private * ``Request::$proxyIPs``: This property will be removed; access ``config('App')->proxyIPs`` directly From 5deea7bbaeccdf8130edd3225a1d59c60ae5b1fa Mon Sep 17 00:00:00 2001 From: kenjis Date: Sun, 25 Dec 2022 09:43:50 +0900 Subject: [PATCH 3/5] docs: fix typo --- user_guide_src/source/installation/upgrade_405.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/user_guide_src/source/installation/upgrade_405.rst b/user_guide_src/source/installation/upgrade_405.rst index 5ea329bb7ef1..651d04ea323a 100644 --- a/user_guide_src/source/installation/upgrade_405.rst +++ b/user_guide_src/source/installation/upgrade_405.rst @@ -44,7 +44,7 @@ Additional related deprecations from the HTTP layer: **ResponseInterface** This interface intends to include the necessary methods for any framework-compatible response class. -A number of methods expected by the framework were missing and have noe been added. If you use any +A number of methods expected by the framework were missing and have now been added. If you use any classes the implement ``ResponseInterface`` directly they will need to be compatible with the updated requirements. These methods are as follows: From 5a7503c1b801e375973defa44d9799e89c47f816 Mon Sep 17 00:00:00 2001 From: kenjis Date: Sun, 25 Dec 2022 09:44:03 +0900 Subject: [PATCH 4/5] docs: remove ; --- .../source/installation/upgrade_405.rst | 32 +++++++++---------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/user_guide_src/source/installation/upgrade_405.rst b/user_guide_src/source/installation/upgrade_405.rst index 651d04ea323a..81a16f8d8ee9 100644 --- a/user_guide_src/source/installation/upgrade_405.rst +++ b/user_guide_src/source/installation/upgrade_405.rst @@ -48,22 +48,22 @@ A number of methods expected by the framework were missing and have now been add classes the implement ``ResponseInterface`` directly they will need to be compatible with the updated requirements. These methods are as follows: -* ``setLastModified($date);`` -* ``setLink(PagerInterface $pager);`` -* ``setJSON($body, bool $unencoded = false);`` -* ``getJSON();`` -* ``setXML($body);`` -* ``getXML();`` -* ``send();`` -* ``sendHeaders();`` -* ``sendBody();`` -* ``setCookie($name, $value = '', $expire = '', $domain = '', $path = '/', $prefix = '', $secure = false, $httponly = false, $samesite = null);`` -* ``hasCookie(string $name, string $value = null, string $prefix = ''): bool;`` -* ``getCookie(string $name = null, string $prefix = '');`` -* ``deleteCookie(string $name = '', string $domain = '', string $path = '/', string $prefix = '');`` -* ``getCookies();`` -* ``redirect(string $uri, string $method = 'auto', int $code = null);`` -* ``download(string $filename = '', $data = '', bool $setMime = false);`` +* ``setLastModified($date)`` +* ``setLink(PagerInterface $pager)`` +* ``setJSON($body, bool $unencoded = false)`` +* ``getJSON(;`` +* ``setXML($body)`` +* ``getXML()`` +* ``send()`` +* ``sendHeaders()`` +* ``sendBody()`` +* ``setCookie($name, $value = '', $expire = '', $domain = '', $path = '/', $prefix = '', $secure = false, $httponly = false, $samesite = null)`` +* ``hasCookie(string $name, string $value = null, string $prefix = ''): bool`` +* ``getCookie(string $name = null, string $prefix = '')`` +* ``deleteCookie(string $name = '', string $domain = '', string $path = '/', string $prefix = '')`` +* ``getCookies()`` +* ``redirect(string $uri, string $method = 'auto', int $code = null)`` +* ``download(string $filename = '', $data = '', bool $setMime = false)`` To facilitate use of this interface these methods have been moved from the framework's ``Response`` into a ``ResponseTrait`` which you may use, and ``DownloadResponse`` now extends ``Response`` directly to ensure maximum compatibility. From c22a3d8a21b77677ed9b59967248b34b9079386e Mon Sep 17 00:00:00 2001 From: kenjis Date: Sun, 25 Dec 2022 09:58:54 +0900 Subject: [PATCH 5/5] docs: fix typo Co-authored-by: Pooya Parsa Dadashi --- user_guide_src/source/installation/upgrade_405.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/user_guide_src/source/installation/upgrade_405.rst b/user_guide_src/source/installation/upgrade_405.rst index 81a16f8d8ee9..b35fb56a1757 100644 --- a/user_guide_src/source/installation/upgrade_405.rst +++ b/user_guide_src/source/installation/upgrade_405.rst @@ -51,7 +51,7 @@ updated requirements. These methods are as follows: * ``setLastModified($date)`` * ``setLink(PagerInterface $pager)`` * ``setJSON($body, bool $unencoded = false)`` -* ``getJSON(;`` +* ``getJSON()`` * ``setXML($body)`` * ``getXML()`` * ``send()``