From 604eac1f20bb8f938adddcd38cf491ce21b234d2 Mon Sep 17 00:00:00 2001 From: Pooya Parsa Dadashi Date: Thu, 27 Apr 2023 23:36:40 +0330 Subject: [PATCH 1/3] add `random_string` to ignoreErrors because shield uses type `nozero` --- phpstan.neon.dist | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/phpstan.neon.dist b/phpstan.neon.dist index 5a406f846..75b50e42f 100644 --- a/phpstan.neon.dist +++ b/phpstan.neon.dist @@ -12,6 +12,10 @@ parameters: ignoreErrors: - '#Call to an undefined method CodeIgniter\\Database\\ConnectionInterface::[A-Za-z].+\(\)#' - '#Cannot access property [\$a-z_]+ on (array|object)#' + - + message: '#Call to deprecated function random_string\(\):#' + count: 5 + path: * universalObjectCratesClasses: - CodeIgniter\Entity - CodeIgniter\Entity\Entity From 82f983a38bee63d40ef411ef8e9a1adc7d83434c Mon Sep 17 00:00:00 2001 From: Pooya Parsa Dadashi Date: Thu, 27 Apr 2023 23:38:17 +0330 Subject: [PATCH 2/3] fix: `$credentials` *NEVER* given --- src/Controllers/LoginController.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Controllers/LoginController.php b/src/Controllers/LoginController.php index 8c5bc445d..dc78426d7 100644 --- a/src/Controllers/LoginController.php +++ b/src/Controllers/LoginController.php @@ -51,7 +51,8 @@ public function loginAction(): RedirectResponse return redirect()->back()->withInput()->with('errors', $this->validator->getErrors()); } - $credentials = $this->request->getPost(setting('Auth.validFields')); + /** @var array $credentials */ + $credentials = $this->request->getPost(setting('Auth.validFields')) ?? []; $credentials = array_filter($credentials); $credentials['password'] = $this->request->getPost('password'); $remember = (bool) $this->request->getPost('remember'); From 397e519c2ba36fcd854bed570576c80eb0fa3e4e Mon Sep 17 00:00:00 2001 From: Pooya Parsa Dadashi Date: Fri, 28 Apr 2023 06:31:02 +0330 Subject: [PATCH 3/3] add all paths for prevent accidental suppression in the project --- phpstan.neon.dist | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/phpstan.neon.dist b/phpstan.neon.dist index 75b50e42f..8c77114cc 100644 --- a/phpstan.neon.dist +++ b/phpstan.neon.dist @@ -14,8 +14,12 @@ parameters: - '#Cannot access property [\$a-z_]+ on (array|object)#' - message: '#Call to deprecated function random_string\(\):#' - count: 5 - path: * + paths: + - src/Authentication/Actions/Email2FA.php + - src/Authentication/Actions/EmailActivator.php + - src/Controllers/MagicLinkController.php + - src/Models/TokenLoginModel.php + - src/Models/UserIdentityModel.php universalObjectCratesClasses: - CodeIgniter\Entity - CodeIgniter\Entity\Entity