Skip to content

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Apr 8, 2024

Description

  • update test code
  • update phpstan-baseline.php

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the testing Pull requests that changes tests only label Apr 8, 2024
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

1) Tests\Unit\AuthRoutesTest::testRoutesCustomNamespace
ErrorException: Undefined array key "register"

P:\MyGitHubWork\shield\tests\Unit\AuthRoutesTest.php:64

--

There were 2 failures:

1) Tests\Unit\AuthRoutesTest::testRoutes
Failed asserting that an array has the key 'register'.

P:\MyGitHubWork\shield\tests\Unit\AuthRoutesTest.php:32

2) Tests\Unit\AuthRoutesTest::testRoutesExcept
Failed asserting that an array has the key 'register'.

P:\MyGitHubWork\shield\tests\Unit\AuthRoutesTest.php:49

For fix get => GET

@kenjis
Copy link
Member Author

kenjis commented Apr 8, 2024

Thank you for the review.
At least, PHPStan errors will be gone.

@kenjis kenjis merged commit af7ddd6 into codeigniter4:develop Apr 8, 2024
@kenjis kenjis deleted the update-test-CI45 branch April 8, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Pull requests that changes tests only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants