[김태완] Sprint 11 #330
Merged
[김태완] Sprint 11 #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyh0521
approved these changes
Dec 9, 2024
| import FAQ from "./components/FAQ"; | ||
| import LoginPage from "./page/LoginPage"; | ||
| import RegisterPage from "./page/RegisterPage"; | ||
| import { useSelector } from "react-redux"; |
Collaborator
There was a problem hiding this comment.
오 프로젝트 하기 전에 미리 리덕스를 활용해보시는군요. 좋습니다 👍
Collaborator
There was a problem hiding this comment.
api 함수들이 점점 늘어나는데 각 함수마다 하나의 파일로 만들어두셔도 좋을 것 같습니다.
| function Header() { | ||
| const [isDropdownVisible, setIsDropdownVisible] = useState(false); | ||
| const dispatch = useDispatch(); | ||
| const count = useSelector((state: any) => state.counter.value); |
Collaborator
There was a problem hiding this comment.
state의 타입을 지정해줄 수 있으면 지정해보셔도 좋을 것 같습니다.
Comment on lines
+14
to
+16
| const toggleDropdown = () => { | ||
| setIsDropdownVisible((prev) => !prev); | ||
| }; |
Collaborator
There was a problem hiding this comment.
토글 함수는 몇번 본 것 같은데 훅 같은거로 만들어보면 어떨까요?
| placeholder, | ||
| }: InputFieldProps) => { | ||
| const [isPasswordVisible, setIsPasswordVisible] = useState<boolean>(false); | ||
| const InputField = forwardRef<HTMLInputElement, InputFieldProps>( |
Collaborator
There was a problem hiding this comment.
forwardRef 잘 사용해주셨는데, 혹시 ref를 사용하는 경우가 있나요? 이번 PR에서는 안보이는 것 같아서요.
Collaborator
Author
There was a problem hiding this comment.
아래 input 태그에서 ref를 사용했습니다!
| <div className="input-pass-box"> | ||
| <input | ||
| ref={ref} | ||
| className={`input-tag ${error ? "input-error" : ""}`} |
Collaborator
There was a problem hiding this comment.
clsx 같은 라이브러리를 활용해보시는 것도 좋을 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
멘토에게