Fix parsing of comment on first line #17
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi @oddbjornkvalsund , thanks for your contribution, I'll take a look at it ASAP this weekend! 👍 |
quintesse
added a commit
that referenced
this pull request
Mar 20, 2023
They would not correctly indicate if they were pointing to a valid element or not. This is now fixed. See #17 for more information
quintesse
added a commit
that referenced
this pull request
Mar 20, 2023
They would not correctly indicate if they were pointing to a valid element or not. This is now fixed. See #17 for more information
Collaborator
|
@oddbjornkvalsund I finally fixed this issue in #19 using your PR as a basis, but an extra fix was necessary and I wanted to redo the tests. So I'm closing this one unmerged but with my sincere thanks! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across a bug in
Cursorthat made parsing of comments on the first line in a file not work.