Skip to content

Conversation

@codejockie
Copy link
Owner

#149986605 fix document controller

#### What does this PR do?
#### This PR removes admin privileges from the document controller

#### Description of Tasks to be completed
#### N/A

#### How should this be manually tested?
#### N/A

#### Any background context you want to provide?
#### No

#### What are the relevant pivotal tracker stories?
#### Fix Document Controller

#### Screenshots (if appropriate)
#### N/A

#### Questions:
#### None

refactor middleware
remove admin privileges on documents

Fixes #149986605
@codejockie codejockie temporarily deployed to cjdocs-pr-30 August 6, 2017 09:40 Inactive
validateUser
} from '../middleware/middleware';
import userController from '../controllers/users';
import m from '../middleware/middleware';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../middleware/middleware' import/no-unresolved
Missing file extension for "../middleware/middleware" import/extensions

validateRole,
validateUser
} from '../middleware/middleware';
import userController from '../controllers/users';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../controllers/users' import/no-unresolved
Missing file extension for "../controllers/users" import/extensions

@@ -1,68 +1,58 @@
import documentController from '../controllers/documents';
import rolesController from '../controllers/roles';
import roleController from '../controllers/roles';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../controllers/roles' import/no-unresolved
Missing file extension for "../controllers/roles" import/extensions

@@ -1,5 +1,5 @@
import models from '../models';
import { documentCreator, isAdmin, isUser } from '../helpers/helper';
import { documentCreator, isUser } from '../helpers/helper';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../helpers/helper' import/no-unresolved
Missing file extension for "../helpers/helper" import/extensions

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 77e90c3 on chore/149986605/fix-document-controller into 2b3dadf on master.

refactor middleware
remove admin privileges on documents

Fixes #149986605
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling aff23ab on chore/149986605/fix-document-controller into 2b3dadf on master.

@codejockie codejockie merged commit 6bc8717 into master Aug 6, 2017
@codejockie codejockie deleted the chore/149986605/fix-document-controller branch May 18, 2018 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants