New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XXE in AdminBackupAction.java #1851

Closed
ProDigySML opened this Issue Sep 29, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@ProDigySML
Copy link

ProDigySML commented Sep 29, 2018

The Issue

An XML External Entity attack is a type of attack against an application that parses XML input. This attack occurs when XML input containing a reference to an external entity is processed by a weakly configured XML parser. This attack may lead to the disclosure of confidential data, denial of service, server side request forgery, port scanning from the perspective of the machine where the parser is located, and other system impacts.

Where the Issue Occurred

The following code snippets display the usage of SAXParserFactory without securely disabling entities:

} else if (fileName.startsWith("gsa") && fileName.endsWith(".xml")) {
final GsaConfigParser configParser = ComponentUtil.getComponent(GsaConfigParser.class);
try (final InputStream in = form.bulkFile.getInputStream()) {
configParser.parse(new InputSource(in));

@marevol marevol closed this in faa265b Sep 29, 2018

marevol added a commit that referenced this issue Sep 29, 2018

marevol added a commit that referenced this issue Sep 29, 2018

@marevol marevol added the improvement label Sep 29, 2018

@marevol marevol added this to the 12.2.3 milestone Sep 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment