fix(webview): route non http(s) schemes out of WebPageView#13
Open
jim-daf wants to merge 1 commit into
Open
Conversation
WebPageView's WebViewClient overrides shouldInterceptRequest, doUpdateVisitedHistory, onPageStarted and onPageFinished but does not override shouldOverrideUrlLoading. Any navigation the loaded supplier page hands the WebView (mailto: on a contact link, tel: on a phone number, intent: from a deep link) is dispatched by the default handler and stays inside the in-app browser. Override shouldOverrideUrlLoading to keep http(s) and about: schemes inside the WebView and route the rest via Intent.ACTION_VIEW, wrapping the launch in try/catch so a missing handler does not crash the Activity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12.
WebPageView'sWebViewClientoverridesshouldInterceptRequest,doUpdateVisitedHistory,onPageStartedandonPageFinished, but notshouldOverrideUrlLoading. Any navigation the loaded supplier page hands the WebView (amailto:on a contact link, atel:on a phone number, anintent:from a deep link) is dispatched by the default handler instead of leaving the in-app browser for the matching system app.Change
Add a
shouldOverrideUrlLoadingoverride. Keephttp,httpsandabout:schemes inside the WebView, route the rest out viaIntent.ACTION_VIEW, wrap the launch intry/catch (ActivityNotFoundException)so a missing handler does not crash the activity:This sits alongside the existing
WARNINGcomment onshouldInterceptRequest. The two hooks serve different roles (one for sub-resource requests, one for top-level navigations) so it does not replace the existing intercept logic.