Bidi text model doesn't take into account wrapped lines #1757

Open
twiss opened this Issue Aug 19, 2013 · 2 comments

Projects

None yet

3 participants

@twiss
Contributor
twiss commented Aug 19, 2013

(Tested everywhere)

Both in chrome and firefox on linux, in a textarea in this case the cursor never jumps (just like on a non-wrapped line), but in CodeMirror with rtlMoveVisually set to true, the cursor moves to the lower part of the rtl text first. I don't know "how wrong" this would seem to a speaker of a rtl language, though.

@marijnh
Member
marijnh commented Aug 20, 2013

Well... it seems there as a huge glaring hole in the current handling of right-to-left text -- in that my code assumes that the text is displayed entirely inverted, whereas it'll only be inverted per-line. Currently, the editor code leaves line breaking entirely up to the browser, and doesn't observe where the line breaks end up, but getting this right would involve changing that somehow. Which is going to be messy.

I am not sure how to go about fixing this. Will think about it a bit more.

#1756 might simply be a different symptom of this problem.

@nadavkav
nadavkav commented Oct 5, 2013

rtlMoveVisually helped me.
Thanks 😄

@marijnh marijnh added the bidi label Oct 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment