3.21.0 breaks runmode.node.js #2188

Closed
amsul opened this Issue Jan 28, 2014 · 4 comments

Comments

Projects
None yet
2 participants
Contributor

amsul commented Jan 28, 2014

It seems as though options is undefined in exports.runMode: https://github.com/marijnh/CodeMirror/blob/master/addon/runmode/runmode.node.js#L104

I tried resolving it in several ways. Including by adding an options parameter as is in runmode.js but that seemed to cause other errors beyond my understanding of the codebase.

Downgrading to 3.20.0 for now as it seems to be intact there.

@marijnh marijnh closed this in 76c9734 Jan 29, 2014

Owner

marijnh commented Jan 29, 2014

Adding the parameter should fix the problem. What further errors are you getting?

Contributor

amsul commented Jan 31, 2014

Yeah it fixes this issue.

However my script continues to execute until I get the warning:

Object [object Object] has no method 'startState'

I believe it has something to do with the "null" mode defined within runmode.node.js. Although it's defined the same way in other areas so I'm not completely sure that's the cause.

Owner

marijnh commented Jan 31, 2014

The null mode doesn't return null when initialized, so I don't think that is the problem. Submit a test case for the startState problem if it can be reproduced.

Contributor

amsul commented Jan 31, 2014

Not quite sure how I would submit a test case for this scenario - but I have given some more context and a fix here: #2207
Hope that helps!

anaran added a commit to anaran/CodeMirror that referenced this issue Feb 22, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment