adding a pane at the top (but not on the bottom) causes the visible content to shift down #4485

Closed
mtaran-google opened this Issue Jan 4, 2017 · 4 comments

Projects

None yet

2 participants

@mtaran-google
Contributor

There should be an option (can be off for backwards compatibility) to not shift the content. The desired effect is that when a pane is added to the bottom it covers up the last ~line, and when a pane is added to the top it covers up the first ~line. All lines not covered up should stay where they were on the screen.

@marijnh
Member
marijnh commented Jan 4, 2017

Should this be possible even when the editor's content is not currently causing a vertical scrollbar? If there's enough scrolling room, this is relatively easy to do -- just scroll the content up by the size of the panel. But that doesn't work when there's no scrollbar or not enough scrollable content below the editor bottom. Would requiring users to enable the scroll/scrollpastend addon to work around this be an acceptable solution?

@marijnh marijnh added a commit that referenced this issue Jan 4, 2017
@marijnh marijnh [panel addon] Implement a 'stable' option
Issue #4485
6928fec
@marijnh
Member
marijnh commented Jan 4, 2017

Attached patch implements this for cases where there's enough scroll room.

@mtaran-google
Contributor

Playing with the demo, it appears that when multiple top panels get created, closing them causes visual scrolling (when there's only one panel things work fine). That seems like a bug. Otherwise, this solution works great.

@marijnh
Member
marijnh commented Jan 5, 2017

Attached patch should make sure closing a stable panel also adjust the scroll position.

@marijnh marijnh closed this Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment