Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility for blind and visually impaired screen reader users #4604

Closed
mjanusauskas opened this issue Feb 24, 2017 · 17 comments
Closed

Accessibility for blind and visually impaired screen reader users #4604

mjanusauskas opened this issue Feb 24, 2017 · 17 comments

Comments

@mjanusauskas
Copy link

@mjanusauskas mjanusauskas commented Feb 24, 2017

The known issue of lack of compatibility with screen readers and assistive technology completely prevents blind and visually impaired screen reader users from being able to use and participate in the enormous number of online tools and resources that use CodeMirror as their editor.
It would be wonderful if the need for full inclusion and accessibility support could be given priority by the CodeMirror community.
A working example of how this can be done quite successfully can be found here:
https://teachaccess.github.io/tutorial/

@adrianheine
Copy link
Contributor

@adrianheine adrianheine commented Feb 25, 2017

I think @marijnh and I are very interested in CodeMirror being accessible and useful to a broad range of people – supporting contentEditable is part of this as far as I know. Without specific funding we will not be able to address broad suggestions such as this, though. If there are specific, easy-to-solve issues, we might be able to fix them on the go.

@mjanusauskas
Copy link
Author

@mjanusauskas mjanusauskas commented Feb 25, 2017

@schanzer
Copy link
Contributor

@schanzer schanzer commented Feb 25, 2017

@mjanusauskas this won't be done soon - proper a11y support isn't easy (otherwise everyone would do it!), and the github tutorial doesn't come close to covering what CM will need. I've been doing significant work on a related project (and contributed small fixes back into CM) to do this right -- and I can assure you that contentEditable is just the beginning of what's needed.

@mjanusauskas
Copy link
Author

@mjanusauskas mjanusauskas commented Feb 25, 2017

@schanzer Thank you for the work you have been doing and for contributing back so many more can benefit from your work. While perhaps not easy, it is certain that incorporating accessibility from the beginning of a design is the best solution to avoiding the far more difficult work of trying to add it in later.

@Neurrone
Copy link

@Neurrone Neurrone commented Jul 17, 2017

Any estimates on roughly how much funding would be required to fund resolution of this issue?

@westonruter
Copy link
Contributor

@westonruter westonruter commented Aug 24, 2017

@adrianheine The WordPress project is looking at integrating CodeMirror into core (see https://github.com/WordPress/codemirror-wp). Given that WordPress puts a high importance on accessibility, there must be interest among the community in funding any needed accessibility improvements as well as funding ongoing maintenance.

@jasonday
Copy link

@jasonday jasonday commented Nov 20, 2017

Without specific funding we will not be able to address broad suggestions such as this, though.

I understand that it will take some work, but choosing to do nothing is actively excluding an entire group of people. The accessibility dev community would likely get involved if an effort was identified.

@marijnh
Copy link
Member

@marijnh marijnh commented Nov 21, 2017

We are aware of the problems and sympathetic to addressing them. The current architecture of the editor (which is still hugely influenced by the initial 'fake everything because browsers aren't reliable' approach) makes this very hard though. We are considering some radical changes, and with luck, we'll have an announcement about that soon. Pull request for low-hanging improvements are always very welcome (if properly documented so that we understand how hey actually improve things).

@jasonday
Copy link

@jasonday jasonday commented Nov 27, 2017

@marijnh & @adrianheine -

Potential approach to establish a baseline level of accessibility for CodeMirror:

Notes:

  • I haven't fully tested these approaches, as there are some complex things happening with the textarea within the CodeMirror js
  • Screenreader only content approach

Approach:

  • Create option for including checkbox to toggle CodeMirror instance for the textarea (formatting only - keeping apis, etc. intact)
  • Or include the checkbox (non-configurable) and hide it offscreen making it available for screenreader users, but not sighted ( I would argue that the option is beneficial for all, not just screenreader users)

-Any edit to the textarea or CodeMirror instance should update the other

demo: https://codepen.io/jasonday/pen/gXdeLm
(checkbox could live in a little settings drop in the upper right)

@schanzer
Copy link
Contributor

@schanzer schanzer commented Dec 6, 2017

@marijnh , would you be open to sharing some of the radical changes you're considering? I've made significant headway on a project aimed at improving the screen-reader accessibility of programming in general, which is built entirely around CodeMirror. I'm both curious about what you're thinking, but also just a little worried that any massive API changes will wreak havoc on my codebase.

@marijnh
Copy link
Member

@marijnh marijnh commented Dec 7, 2017

would you be open to sharing some of the radical changes you're considering?

We intend to move to contentEditable more completely. There'll be an announcement sometimes in the coming months when we have the design worked out more clearly.

but also just a little worried that any massive API changes will wreak havoc on my codebase.

Oh yeah, that will definitely happen, and upgrading will take some work.

@QuincyLarson
Copy link

@QuincyLarson QuincyLarson commented Jan 1, 2018

@marijnh This issue is really important to the freeCodeCamp.org community, which has many members who have visual impairments or are completely blind. Is there anything we can do to help with this?

@marijnh
Copy link
Member

@marijnh marijnh commented Jan 1, 2018

@QuincyLarson Yes, there'll be work on a more accessible architecture starting in a few months. If you want to contribute financially or be involved in testing, shoot me an email!

@tyrylu
Copy link

@tyrylu tyrylu commented Aug 20, 2019

Any progress on this one?

@marijnh
Copy link
Member

@marijnh marijnh commented Aug 21, 2019

Work on CodeMirror 6 is progressing in this repository.

@tyrylu
Copy link

@tyrylu tyrylu commented Aug 21, 2019

Thank you, 6.x looks nice from the accessibility perspective.

@adil-s
Copy link

@adil-s adil-s commented Mar 30, 2020

any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
10 participants