Obsidian.md: Undo (Ctrl+Z) undoes more than one last step

[mikkovedru]

I am using Obsidian knowledge base editor.

I found a bug in it, reported it to the developers, but it was shot down on the grounds of "it is a CodeMirror bug". Hence I am writing to you.

Here is a copy&paste of my original bug report:

---

Steps to reproduce

0. Install Obsidian.
1. Go to any youtube video (for example here)
2. Select one line with the name of the channel (in this case “DistroTube”)
   
3. Write "Test " in a document.
4. Press Ctrl+Ins(Ctrl+C) to copy.
5. Go to Obsidian document and write "Test ".
6. Press Shift+Ins (Ctrl+V) to paste. The result should look like this:

Test [DistroTube](https://www.youtube.com/channel/UCVls1GmFKf6WlTraIb_IaJg)

7. BUG: Press Ctrl+Z to undo. You will see that the whole line will be deleted, not only the youtube link.

Expected result

Only the last step should be undoed. Typing and pasting are clearly two different steps/activities.
Environment

• Operating system: Linux Mint 20.2 Cinnamon
• Obsidian version: 0.12.10

Additional information

This bug shows itself with youtube channel links. Everything works fine with most other copy-pasted text. Including if you paste+select+copy the same exact youtube channel link and try to reproduce the bug…

---

[marijnh]

Sorry, I'm not debugging problems that involve integrations. And more generally, not very sure that this is a CodeMirror bug. It sounds like the Obsidian link pasting behavior replaces the entire line, and that's what's causing this behavior.

[lishid]

Got word of this recently. Here's the repro on https://codemirror.net/:

Type this into console:

editor.on('paste', (cm, e) => {
  cm.replaceSelection('test');
  e.preventDefault();
});

Create new line, then type anything, then paste anything, then undo undoes both the typing and pasting.

[marijnh]

That's by design -- replaceSelection defaults to setting the "origin" of the change to +input, which allows the change to be merge with other plain input changes. Call .replaceSelection("test", false, "customOrigin") to avoid this.

[lishid]

Ah I see, thanks for the response!