Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GFM indented fenced code block fails to exit for some inner parsers #6884

Open
lishid opened this issue Feb 21, 2022 · 2 comments
Open

GFM indented fenced code block fails to exit for some inner parsers #6884

lishid opened this issue Feb 21, 2022 · 2 comments

Comments

@lishid
Copy link
Contributor

@lishid lishid commented Feb 21, 2022

Open https://codemirror.net/mode/gfm/index.html

Run the following code in console to enable shell language.

let s = document.createElement('script');
s.src='../shell/shell.js';
document.head.appendChild(s);

Type the following into the editor:

- list
	```shell
	cat <<
	```

Some more text

Expected: Some more text should not be highlighted
Actual:
image

@marijnh
Copy link
Member

@marijnh marijnh commented Feb 22, 2022

Weren't you using CM6? The Markdown stuff should definitely be a lot less broken there. The CM5 Markdown/GFM stuff is definitely in low-maintenance mode (it's contributed code, and not in great shape).

@lishid
Copy link
Contributor Author

@lishid lishid commented Feb 22, 2022

Weren't you using CM6?

That is correct, we are in the middle of an awkward migration phase from CM5 to CM6 where we currently still offer CM5 as a legacy editor, and uses a proxy object to expose a common interface for interacting with both CM5 and CM6.

For parsing we are, unfortunately, still stuck on the old CM5 parsers through stream-parser until we can fully remove CM5 from the codebase after which we would be able to commit a big chunk of development time to rewrite our markdown flavor in CM6's lezer.

The CM5 Markdown/GFM stuff is definitely in low-maintenance mode (it's contributed code, and not in great shape).

Ok fair enough, that's understandable. I will see if I can find some time to fix this one from our end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants