New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overlapping scroll thumbs appear on Lion #727
Comments
This is a temporary kludge. I hope we'll be able to find a better solution. (This should bring back the flicker issue on Lion.) Issue #727
I'm working on a new scrolling model (tracked in #730) that I think will fix this. It's a pretty bizarre hack (basically, making the scroller bigger than the wrapper, in order to hide its scrollbars, and then compensating for this with padding and overflow: hidden on the wrapper), but it seems to work on all supported browsers. |
The v3 branch now contains the solution outlined above. It seems to work. |
Hi Marijn--sorry for the late response on this. I just tried demo/theme.html in the v3 branch, pasting in a long file, and on Lion I don't see the scroll thumb at all (though it does scroll if I use the touchpad). Also, the scrolling is flickery on long/fast throws. |
I should mention that I'm testing in Chrome 21.0.1180.89. |
That's not surprising. I haven't debugged at all on Lion, so there's bound to be some issues with A) getting the fake scrollbar div to even display its scrollbar (it's probably getting its width set to zero since scrollbars take up zero space), and B) correctly handling mouse clicks in that scrollbar. Will you have time to debug this somewhere this month? I tried to install Mountain Lion on my old MacBook Pro (couldn't find 10.7 in the app store), but it claims that the computer isn't compatible with that version (though it meets all the requirements listed at http://support.apple.com/kb/HT5444). So, since I don't currently have much intention to pay large amounts of money for a new Apple laptop, I am not able to test and debug this. |
With the above patch, scrollbars seem to work for me on Lion (which I managed to install through a somewhat creative process) on v3. In 2.x, I intend to leave things as they are (fake scrollbar disabled, so flickering present, but otherwise all should be fine). |
Yup, looks like the scrollbars are working again--and I can grab them as well, which is great! I'm still seeing noticeable flicker on long throws, especially in the gutter area. There's also a minor visual issue with the fake scrollbar on Mountain Lion (which changed the scrollbars slightly yet again...). I'll file separate bugs on these. |
As of commit 472d099
Result: You see two overlapping scrollbar thumbs on the right. They diverge more and more as you get closer to the bottom of the code. (Even if they matched, though, it would still look wrong since the scrollbar thumb would be twice as dark as usual.)
The text was updated successfully, but these errors were encountered: