Come up with some comprehensive indentation model for multiline comments #854

Closed
marijnh opened this Issue Sep 28, 2012 · 1 comment

Comments

Projects
None yet
1 participant
@marijnh
Owner

marijnh commented Sep 28, 2012

Currently, they are simply set to indentation zero by most of the modes. It would be nice if gives you the indentation of the line before, and block-reindent preserves the current indentation.

marijnh added a commit that referenced this issue Sep 28, 2012

[javascript&clike modes] Indent block comments with CodeMirror.Pass
This'll align them with the previous line. It's not a perfect solution,
but probably better than simply returning 0.

Issue #854

marijnh added a commit that referenced this issue Sep 28, 2012

[javascript&clike modes] Indent block comments with CodeMirror.Pass
This'll align them with the previous line. It's not a perfect solution,
but probably better than simply returning 0.

Issue #854
@marijnh

This comment has been minimized.

Show comment Hide comment
@marijnh

marijnh May 20, 2013

Owner

The current approach of returning CodeMirror.Pass works reasonably well, and doesn't add too much complexity.

Owner

marijnh commented May 20, 2013

The current approach of returning CodeMirror.Pass works reasonably well, and doesn't add too much complexity.

@marijnh marijnh closed this May 20, 2013

RaymondLim pushed a commit to adobe/CodeMirror2 that referenced this issue Aug 30, 2013

Josh Hatwich
Fix for brackets issue #854
When typing invalidates the redo stack the dirtyCounter needs to shift
to a range where it won't hit zero again (the path back to clean has
been destroyed as far as undo is concerned).

gruehle added a commit to adobe/CodeMirror2 that referenced this issue Aug 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment