Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Pass givenObjects to hint functions, add option for additional context. #1066

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

mhils commented Dec 8, 2012

This pull requests contains two changes:
The first change is that simpleHint hands the given options object over to the hinting function. This is useful if your hinting function comes with configuration options.
The second change adds an additionalContext option to javascriptHint. This way, autocompletion can be established for objects that are not in the window scope. (obviously depends on the first change)

I hope you welcome these additions.

Thanks!

@marijnh marijnh added a commit that referenced this pull request Dec 10, 2012

@marijnh marijnh [javascript hinter] Support additionalContext option
Issue #1066
5a2456c

@marijnh marijnh added a commit that referenced this pull request Dec 10, 2012

@marijnh marijnh [javascript hinter] Support additionalContext option
Issue #1066
5497f68
Owner

marijnh commented Dec 10, 2012

Good idea. Merged. But I rewrote the second patch to be a bit simpler by not including the whole default-filling mechanism. That looked like overkill.

@marijnh marijnh closed this Dec 10, 2012

Contributor

mhils commented Dec 10, 2012

Thanks for the quick merge and the improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment