Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Dylan mode #2352

Closed
wants to merge 17 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

waywardmonkeys commented Mar 11, 2014

No description provided.

Owner

marijnh commented Mar 11, 2014

You are not supposed to define your own token styles + css file. Use the styles in lib/codemirror.css, so that the mode works with all themes. Most of your styles match an existing token style directly. For the others, you'll have to just pick an unused style that sort of sounds like it might apply.

Contributor

waywardmonkeys commented Mar 11, 2014

Okay, it should be better now.

marijnh added a commit that referenced this pull request Mar 11, 2014

Owner

marijnh commented Mar 11, 2014

I've merged this as af4dedb, but I've shamelessly reindented the code to match the rest of the CodeMirror codebase. Some more small cleanups in 4d9be84. The indentation mechanism in the code wasn't even close to doing proper indentation, so I've simply removed it.

@marijnh marijnh closed this Mar 11, 2014

@waywardmonkeys waywardmonkeys deleted the waywardmonkeys:dylan-mode branch Mar 11, 2014

Contributor

waywardmonkeys commented Mar 11, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment