Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vim] blockwise paste #2751

Closed
wants to merge 5 commits into from
Closed

Conversation

binora
Copy link

@binora binora commented Aug 5, 2014

blockwise paste implementation

@binora
Copy link
Author

binora commented Aug 5, 2014

@mightyguava @heppe Please have a look.

@mightyguava
Copy link
Contributor

I found 2 bugs so far.

  1. The block ends up getting pasted in the column before the cursor. It should be on the column after the cursor.
  2. If the column the cursor on exceeds the length of the line below, vim should extend the line below with whitespace/tabs to match the column. Right now it just pastes to the end of the line.

@heppe
Copy link
Contributor

heppe commented Aug 6, 2014

@mightyguava I wasn't able to repro #1 from your list, but I don't see a commit after your comment, so I'm not sure how it might have been fixed.

I was able to see #2, however, and it's worse than you describe. It doesn't paste at the end of the line, but rather chucks out whatever contents were on the line past the shortest line that is touched by the pasted block. That definitely needs a fix and a test before this can be submitted.

@heppe
Copy link
Contributor

heppe commented Aug 11, 2014

LGTM. This looks ready to merge.

@mightyguava
Copy link
Contributor

Merged as 9de315b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants