New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dockerfile mode] Add regex to fallback tokens #2964

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@parisk
Copy link
Contributor

parisk commented Dec 4, 2014

Adding en empty line in the middle of a Dockerfile and starting typing led to blocking of CodeMirror.

[Dockerfile mode] Add regex to fallback tokens
The absence of a regular expression for fallback tokens, made CodeMirror block and throw an exception, when writing in empty line in the middle of the code.

`Mode dockerfile failed to advance stream.`

marijnh added a commit that referenced this pull request Dec 4, 2014

@marijnh

This comment has been minimized.

Copy link
Member

marijnh commented Dec 4, 2014

That was indeed bad. I've pushed an alternative patch (88b1d82) which fixes it without doing silly things like setting a token property to a regexp, and also cleans up some unnecessary next properties (staying in the same state is implicit).

@marijnh marijnh closed this Dec 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment