Various minor parser bugs noticed by the Closure compiler. #84

Merged
merged 1 commit into from May 2, 2011

Conversation

Projects
None yet
2 participants
@artdent
Contributor

artdent commented May 1, 2011

  • Trailing commas in object literals are not allowed by the spec and are handled poorly in some browsers.
  • Added var to some variable declarations that were not meant to be globals.
Various minor parser bugs noticed by the Closure compiler.
- Trailing commas in object literals are not allowed by the spec
  and are handled poorly in some browsers.
- Added var to some variable declarations that were not meant to be globals.

marijnh added a commit that referenced this pull request May 2, 2011

Merge pull request #84 from artdent/master.
Various minor parser bugs noticed by the Closure compiler.

@marijnh marijnh merged commit 3814e20 into codemirror:master May 2, 2011

@marijnh

This comment has been minimized.

Show comment Hide comment
@marijnh

marijnh May 2, 2011

Owner

Thanks for noticing those!

Owner

marijnh commented May 2, 2011

Thanks for noticing those!

@artdent

This comment has been minimized.

Show comment Hide comment
@artdent

artdent May 4, 2011

Contributor

I don't see this commit in master anymore. Did a subsequent push accidentally orphan it?

Contributor

artdent commented May 4, 2011

I don't see this commit in master anymore. Did a subsequent push accidentally orphan it?

@marijnh

This comment has been minimized.

Show comment Hide comment
@marijnh

marijnh May 4, 2011

Owner

I have no idea. The github automerge feature seems to be a bit screwy. I've merged it again, the old-fashioned way.

Owner

marijnh commented May 4, 2011

I have no idea. The github automerge feature seems to be a bit screwy. I've merged it again, the old-fashioned way.

@artdent

This comment has been minimized.

Show comment Hide comment
@artdent

artdent May 5, 2011

Contributor

Thanks!

Contributor

artdent commented May 5, 2011

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment