Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't enter "ł" (Polish letter) using external keyboard on iOS #474

Closed
balance-wtf opened this issue Apr 29, 2021 · 6 comments
Closed

Can't enter "ł" (Polish letter) using external keyboard on iOS #474

balance-wtf opened this issue Apr 29, 2021 · 6 comments

Comments

@balance-wtf
Copy link

@balance-wtf balance-wtf commented Apr 29, 2021

Can't enter "ł" (Polish letter) using external keyboard on iOS which is done by pressing alt + l. Doesn't work on the codemirror website, or in any app using CodeMirror 6. All other Polish diacritic letters work (ó, ż, ź, ą, ę, ś, ć, ń).

Tested this on Windows & Android - working all good. So only applies to iOS/iPadOS 14.4 (version I'm currently using).

marijnh added a commit to codemirror/commands that referenced this issue Apr 29, 2021
FIX: Use Ctrl-l, not Alt-l, to bind `selectLine` on macOS, to avoid conflicting
with special-character-insertion bindings.

Issue codemirror/codemirror.next#474
@marijnh
Copy link
Member

@marijnh marijnh commented Apr 29, 2021

This is probably because the editor binds Alt-l to selectLine. Does attached patch work for you?

@lishid
Copy link

@lishid lishid commented Apr 29, 2021

Seems like the patch only changed the comments but not the code itself... I got a report about this too recently.

marijnh added a commit to codemirror/commands that referenced this issue Apr 30, 2021
@marijnh
Copy link
Member

@marijnh marijnh commented Apr 30, 2021

Ugh, sorry, I got distracted halfway through. Followed up with another patch.

@balance-wtf
Copy link
Author

@balance-wtf balance-wtf commented Apr 30, 2021

Looks all good to me 👌

Thanks @marijnh for the quick reply :)

@balance-wtf
Copy link
Author

@balance-wtf balance-wtf commented May 6, 2021

Heya @marijnh any idea when will this be added to a release? Using an app built on CodeMirror 6 as my daily driver, kinda impacting my workflow quite a lot.

@marijnh
Copy link
Member

@marijnh marijnh commented May 6, 2021

Ah, right. I've tagged @codemirror/commands 0.18.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants