Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backspace Behaviour with Thai (could be other languages too) #686

Closed
CalmDownMonkey opened this issue Jan 14, 2022 · 1 comment
Closed

Backspace Behaviour with Thai (could be other languages too) #686

CalmDownMonkey opened this issue Jan 14, 2022 · 1 comment

Comments

@CalmDownMonkey
Copy link

@CalmDownMonkey CalmDownMonkey commented Jan 14, 2022

Steps to reproduce

  1. Type a Thai word, like ที่
  2. Press backspace

(if you add a Thai keyboard layout via your OS to test this, you can create this character by pressing in sequence, "muj")

Expected result

The first press of backspace should reduce ที่ to ที, then again, to ท, before deleting the entire character.

Actual result

Backspace deletes the entire word ที่ in one go, including all vowels and tone marks, meaning you have to start that character again if you do a typo. This makes typing in Thai quite difficult.

Obsidian the note-taking application recently switched to using CodeMirror 6 as its editor, which exposed me to this issue. I raised the issue with them here, and they pointed me to the CodeMirror issue list.
I can replicate the issue on the demo page.

Thanks!

marijnh added a commit to codemirror/text that referenced this issue Jan 14, 2022
FEATURE: `findClusterBreak` now takes an optional `includeExtending`
argument that determines whether it skips over extending characters.

Issue codemirror/codemirror.next#686
@marijnh
Copy link
Member

@marijnh marijnh commented Jan 14, 2022

Interesting — Thai input doesn't seem to use IME/composition features, and just works in plain editing mode, even when composing/decomposing characters.

This was broken by the patch created for #516. Attached patches further refine how combined glyphs are backspaced and should address this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants