Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS deadkey composition #714

Closed
lishid opened this issue Feb 3, 2022 · 14 comments
Closed

macOS deadkey composition #714

lishid opened this issue Feb 3, 2022 · 14 comments

Comments

@lishid
Copy link

@lishid lishid commented Feb 3, 2022

Seeing an inconsistent treatment for the backtick deadkey at the start of the line which is used to insert accented characters like à with some keyboard layouts. The same layout combo works fine on Windows.

To reproduce:

  • macOS Chrome.
  • Set the keyboard layout to English "U.S. International - PC".
  • Try typing <backtick> + a.
  • Observe that it only works sometimes.

test

@marijnh
Copy link
Member

@marijnh marijnh commented Feb 4, 2022

Also not happening with dead key layouts on Linux. Will try to test on macOS soon.

@marijnh
Copy link
Member

@marijnh marijnh commented Feb 7, 2022

I can't this to occur in Chrome 98 on macOS (tried about 20 times).

@lishid
Copy link
Author

@lishid lishid commented Feb 7, 2022

Maybe it's an OS issue? I'm testing on macOS Big Sur V11.6 Intel.
Just updated Chrome to 98 and can still repro exactly as the previous gif.

@marijnh
Copy link
Member

@marijnh marijnh commented Feb 7, 2022

Yes, I tested with an empty editor. Not entirely sure what the OS version was on the laptop, will check.

@marijnh
Copy link
Member

@marijnh marijnh commented Feb 8, 2022

Upgraded macOS from 10.something, where the problem didn't occur, to 12.2, where I still don't see it.

@WhiteNoiseDev
Copy link

@WhiteNoiseDev WhiteNoiseDev commented Feb 8, 2022

Did you set the keyboard layout to "U.S. International - PC"?
Also is the OS doing the deadkey management or do you have keyboard that does it at a lower level?

@marijnh
Copy link
Member

@marijnh marijnh commented Feb 8, 2022

Yes, I set that keyboard and composed à chacters by typing a backtick and then a. I don't think my keyboard does something like this, no (plain old macbook laptop keyboard).

@lishid
Copy link
Author

@lishid lishid commented Feb 8, 2022

Here's the original bug report: https://forum.obsidian.md/t/extra-backtick-when-used-as-dead-key/30412
The report mentions macOS 12.1.
Oddly, it mentions the use of the option key "⌥`"

@lishid
Copy link
Author

@lishid lishid commented Feb 8, 2022

Update: I can also repro this in Safari on the website. macOS 11.6 as well.

test

@WhiteNoiseDev
Copy link

@WhiteNoiseDev WhiteNoiseDev commented Feb 8, 2022

They mention the option key because in some layouts to get ` (and hence trigger the deadkey behavior) you need to physically press option+<another button> (e.g. option-9 in the Italian layout)

@habarahonaa
Copy link

@habarahonaa habarahonaa commented Feb 12, 2022

https://forum.obsidian.md/t/extra-backtick-when-used-as-dead-key/30412

I can repro this on Chrome 97 macOS 12.2. Perhaps an issue with autocomplete is causing it?

marijnh added a commit to codemirror/view that referenced this issue Feb 17, 2022
FEATURE: The new `EditorView.compositionStarted` property indicates
whether a composition is starting.

Issue codemirror/codemirror.next#714
marijnh added a commit to codemirror/closebrackets that referenced this issue Feb 17, 2022
FIX: Don't close brackets when a composition has started, to avoid breaking
dead key input.

Issue codemirror/codemirror.next#714
@marijnh
Copy link
Member

@marijnh marijnh commented Feb 17, 2022

It looks like this may just be the closebrackets package interfering with the composition. Could you see if turning that off resolves the issue?

@lishid
Copy link
Author

@lishid lishid commented Feb 17, 2022

It does seem to work just fine without closebrackets.

@marijnh
Copy link
Member

@marijnh marijnh commented Feb 17, 2022

I've tagged @codemirror/closebrackets 0.19.1, which should help.

@marijnh marijnh closed this Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants