Commits on Feb 20, 2015

  1. Make inputStyle an option, move relevant logic into TextareaInput 

    Add a dummy ContentEditableInput
    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    0dc2189 View commit details
    Browse the repository at this point in the history

  2. Wire up some actual logic to ContentEditableInput 

    Simple things work.
    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    f2b49d1 View commit details
    Browse the repository at this point in the history

  3. Suppress mouse event handling during touch

    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    a1664f6 View commit details
    Browse the repository at this point in the history

  4. Support clipboard events, fix some selection issues

    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    8bec859 View commit details
    Browse the repository at this point in the history

  5. Clean up some FIXMEs

    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    3f45d4e View commit details
    Browse the repository at this point in the history

  6. Make selection drawing work when the viewport doesn't cover the selec… 

    …tion
    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    594a301 View commit details
    Browse the repository at this point in the history

  7. Further tweaks to selection polling 

    Still doesn't work properly
    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    af059b4 View commit details
    Browse the repository at this point in the history

  8. Add scanning of surrounding dom nodes when looking for a selection node

    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    68b04f0 View commit details
    Browse the repository at this point in the history

  9. More selection nonsense

    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    3082017 View commit details
    Browse the repository at this point in the history

  10. Don't disable mouse events during touch when using textarea input

    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    a3af04e View commit details
    Browse the repository at this point in the history

  11. Make tests more or less run with contenteditable backend

    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    5df0ce7 View commit details
    Browse the repository at this point in the history

  12. Don't poll for selection during composition

    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    3ab057f View commit details
    Browse the repository at this point in the history

  13. Draw secondary selections in contentEditable input model

    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    5e834b9 View commit details
    Browse the repository at this point in the history

  14. Place cursor at correct offset in bidi text

    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    4891ba3 View commit details
    Browse the repository at this point in the history

  15. Improve handling of composition events

    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    4f20778 View commit details
    Browse the repository at this point in the history

  16. Fix focus issue in Firefox

    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    2ba1798 View commit details
    Browse the repository at this point in the history

  17. Don't treat single-pixel-radius touch events as touch events

    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    9ddfe1f View commit details
    Browse the repository at this point in the history

  18. [contenteditable input] React to input invent by reading text from DOM

    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    45229e2 View commit details
    Browse the repository at this point in the history

  19. Override tap events to avoid Chrome's magnifying behavior 

    It apparently believes that if the editor's nodes are directly next to
each other without margin, the user needs a magnifying glass to pick
a cursor position.
    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    0dc7c20 View commit details
    Browse the repository at this point in the history

  20. [contenteditable input] Properly handle compositionend events

    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    72d5c41 View commit details
    Browse the repository at this point in the history

  21. [contenteditable input] Kill composition when key is handled or input… 

    … is reset
    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    4734f2f View commit details
    Browse the repository at this point in the history

  22. Style in-editor selections to match default selection style 

    So that the contenteditable input style doesn't look silly
on desktop.
    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    e3748a2 View commit details
    Browse the repository at this point in the history

  23. [contenteditable input] Make dom poll hack work with tabs and special… 

    … chars
    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    9c874be View commit details
    Browse the repository at this point in the history

  24. Force redraw of native selection when it is in a bogus state 

    I.e. when the cursor is directly in the editor's top node or outside of a line's
<pre> node.
    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    0f227d3 View commit details
    Browse the repository at this point in the history

  25. [contenteditable input] Improve handling of forced completionend

    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    8956ff5 View commit details
    Browse the repository at this point in the history

  26. [contenteditable input] Make sure zero-width elements aren't counted … 

    …as text
    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    54df599 View commit details
    Browse the repository at this point in the history

  27. [contenteditable input] Guard against wrapped or replaced nodes in pa… 

    …tchDisplay
    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    6ed2b86 View commit details
    Browse the repository at this point in the history

  28. [contenteditable input] Try to handle Google Keyboard's weird composi… 

    …tion events
    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    f396f8f View commit details
    Browse the repository at this point in the history

  29. Work around broken iOS clipboard API

    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    42c3cad View commit details
    Browse the repository at this point in the history

  30. [contenteditable input] Fix empty array issues in pollContent

    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    3baa1c1 View commit details
    Browse the repository at this point in the history

  31. [contenteditable input] Resolve race condition in composition end

    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    505f696 View commit details
    Browse the repository at this point in the history

  32. [contenteditable input] Fix pollContent when cursor ends up in a zero… 

    …-width element
    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    3f60ed5 View commit details
    Browse the repository at this point in the history

  33. Don't immediately focus on click in IE 

    It can create a kind of phantom-focus state where the textarea
is focused but you can't type into it.

Issue #3041
    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    60ef248 View commit details
    Browse the repository at this point in the history

  34. When polling input, set prevInput before ending the operation 

    Since that might end up calling resetInput and creating an
inconsistent state.

Issue #3046
    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    0f5030a View commit details
    Browse the repository at this point in the history

  35. Fix for copying large chunks of text 

    Selecting and copying a large chunk of text places a single dash into clipboard.

This is related to line 1285, where the input's content is trimmed for performance:

https://github.com/codemirror/CodeMirror/blob/mobile/lib/codemirror.js#L1285

    minimal = hasCopyEvent &&
      (range.to().line - range.from().line > 100 || (selected = cm.getSelection()).length > 1000);
    var content = minimal ? "-" : selected || cm.getSelection();

The problem is apparently a typo during refactoring/renaming from 'd' on the master branch to 'input' here.
    @mihailik @marijnh
    mihailik authored and marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    6873df1 View commit details
    Browse the repository at this point in the history

  36. Don't try to use contenteditable=plaintext-only 

    Since Mobile Chrome's clipboard API is broken and does not let us
intercept paste events, we need full contenteditable to be able
to paste code with newlines.

Issue #3062
    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    926ce11 View commit details
    Browse the repository at this point in the history

  37. [contenteditable input] Fix bug in pollContent

    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    7ae24f7 View commit details
    Browse the repository at this point in the history

  38. [contenteditable input] Fix selection adjustment for compositionstart

    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    2348657 View commit details
    Browse the repository at this point in the history

  39. [contenteditable input] Fix compositionend data-overwriting exception

    @marijnh
    marijnh committed Feb 20, 2015
    2 Configuration menu
    Copy the full SHA
    6ef5f8b View commit details
    Browse the repository at this point in the history

  40. [contenteditable input] Force composition end on touchstart event

    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    5cf6e87 View commit details
    Browse the repository at this point in the history

  41. Handle double- and triple-tap events ourselves 

    Since preventDefaulting the first touchend event means the native
behavior won't happen anymore, this is seems to be the only way
to make multi-tap work for iOS.
    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    2ec7737 View commit details
    Browse the repository at this point in the history

  42. [contenteditable input] Only return true from pollContent when an act… 

    …ual change was found

So that styling content causes a redraw, removing the style
    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    025d1a8 View commit details
    Browse the repository at this point in the history

  43. [contenteditable display] Fix polling for collapsed text

    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    b6fed25 View commit details
    Browse the repository at this point in the history

  44. [contenteditable input] Fix another bug in pollContent 

    Typing the same character multiple times in a row would
cause a character to be deleted.
    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    9914eb7 View commit details
    Browse the repository at this point in the history

  45. [contenteditable input] Fix selection-to-pos hack when node is a span… 

    … around a text node
    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    8f74e74 View commit details
    Browse the repository at this point in the history

  46. Document inputStyle option

    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    c1e30b8 View commit details
    Browse the repository at this point in the history

  47. Mark release 5.0

    @marijnh
    marijnh committed Feb 20, 2015
    Configuration menu
    Copy the full SHA
    289b647 View commit details
    Browse the repository at this point in the history