Radically improve Django mode #3197
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves radically the Django mode by introducing more features and fixing some bugs.
In detail, this pull request introduces the following
blockCommentStartandblockCommentEndvariable,tag,comment)This pull request also fixes two major bugs that made highlighting break:
The only oddball in this pull request is the
"null"token styling. Since thedjangomode is an overlay ofdjango:inneroverhtml, when using Django templates in HTML tag attributes, returningnullresults in string styling (because of the HTML tag attribute), instead of no styling. For this reason I returned"null"to avoid this.The Django template language is described extensively at https://docs.djangoproject.com/en/1.8/ref/templates/language
This pull request can be tested at https://codemirror-paris.apps.lair.io/mode/django/index.html