Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Better pinch-to-zoom #2786
Thank you for your support.
I replied to your comment to my question about the new cropping feature:
On real devices, the ImageViewer cropping works, but the pinch-to-zoom doesn't work very well: on Android 7, at the end of the pinch-to-zoom the image is sometimes moved to the top-left corner or the bottom-right corner without reason; on iPhone X, the pinch-to-zoom seems not fluid and, when the zoom is big, the image becomes all black (it returns visible reducing the zoom).
Could you please make the pinch-to-zoom working better?
The code that I used is the one reported in the link above.
I've tested on iOS now. In response to your observations:
I see what you mean. Panning is smooth. Pinch zoom is a little bit choppy. IMO still quite usable. I'll see what I can do to improve this.
This happens when the image size crosses the device's max texture size threshold. On iOS, images get rendered as OGL textures. Working on fixing this now.