Replace LRU with SIEVE replacement policy#1971
Merged
ostafen merged 1 commit intocodenotary:masterfrom May 17, 2024
Merged
Conversation
Collaborator
Signed-off-by: Stefano Scafiti <stefano.scafiti96@gmail.com>
ostafen
force-pushed
the
feature/sieve-caching-policy
branch
from
df033b1 to
12ce94e
Compare
Razikus
approved these changes
May 17, 2024
| } | ||
|
|
||
| c.lruList.MoveToBack(e.order) | ||
| atomic.StoreUint32(&e.visited, 1) |
There was a problem hiding this comment.
Why atomic if both get/evict hold the lock?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paper: https://junchengyang.com/publication/nsdi24-SIEVE.pdf