This repository was archived by the owner on Mar 10, 2024. It is now read-only.
set default log level to warning #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
log level from env
zvikagart
suggested changes
Mar 5, 2021
jupyter_matlab_proxy/app.py
Outdated
| from .gui.static import media | ||
|
|
||
| logging.basicConfig(level=logging.INFO) | ||
| logLevel=logging.WARNING |
There was a problem hiding this comment.
To preserve compatibility with upstream I recommend to keep the default log level as info and override with the env var in our system
jupyter_matlab_proxy/app.py
Outdated
| logging.basicConfig(level=logging.INFO) | ||
| logLevel=logging.WARNING | ||
| if os.environ.get("LOG_LEVEL") is not None: | ||
| lvl = logging._nameToLevel.get(os.environ.get("LOG_LEVEL").upper()) |
There was a problem hiding this comment.
Using private fields is not recommended.
Two other approaches:
https://stackoverflow.com/a/60679407
https://stackoverflow.com/a/35689599
shay-k
added a commit
that referenced
this pull request
Mar 9, 2021
shay-k
added a commit
that referenced
this pull request
Mar 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log level from env