From 6821163d97b593222bcb3c7345e69870d9477bbd Mon Sep 17 00:00:00 2001 From: shay Date: Thu, 4 Mar 2021 17:23:10 +0200 Subject: [PATCH 1/2] set default log level to warning log level from env --- jupyter_matlab_proxy/app.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/jupyter_matlab_proxy/app.py b/jupyter_matlab_proxy/app.py index b9b6c98a..8bb0ab2f 100644 --- a/jupyter_matlab_proxy/app.py +++ b/jupyter_matlab_proxy/app.py @@ -28,7 +28,13 @@ from .gui.static import js from .gui.static import media -logging.basicConfig(level=logging.INFO) +logLevel=logging.WARNING +if os.environ.get("LOG_LEVEL") is not None: + lvl = logging._nameToLevel.get(os.environ.get("LOG_LEVEL").upper()) + if lvl is not None: + logLevel=lvl + +logging.basicConfig(level=logLevel) logger = logging.getLogger("MATLABProxyApp") # TODO It is bad practice to have global state in aiohttp applications, instead this From ee348188a16c968bc955bb4b6f701b3d7e226d17 Mon Sep 17 00:00:00 2001 From: shay Date: Sun, 7 Mar 2021 10:52:11 +0200 Subject: [PATCH 2/2] pr fixes --- jupyter_matlab_proxy/app.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jupyter_matlab_proxy/app.py b/jupyter_matlab_proxy/app.py index 8bb0ab2f..854f46a6 100644 --- a/jupyter_matlab_proxy/app.py +++ b/jupyter_matlab_proxy/app.py @@ -28,9 +28,9 @@ from .gui.static import js from .gui.static import media -logLevel=logging.WARNING +logLevel=logging.INFO if os.environ.get("LOG_LEVEL") is not None: - lvl = logging._nameToLevel.get(os.environ.get("LOG_LEVEL").upper()) + lvl = getattr(logging, os.environ.get("LOG_LEVEL"), logging.INFO) if lvl is not None: logLevel=lvl