Subpath shouldn't match partial URL segments. e.g. /resources/1 vs /resources_group/1 #109

Merged
merged 1 commit into from Nov 26, 2012

Conversation

Projects
None yet
3 participants
Contributor

troynt commented Sep 26, 2012

If you are using subpath it will match

/resources/1

and

/resources_group/1

If subpath is set on resources.

This is not desirable.

Should only match

/resources/*
/resources
/resources?*
/ReSouRces

I added a test, but I couldn't figure out how to run them. I get controller mock undefined errors.
undefined method `request' for #ControllerMock:0x00000003d0d290

However, I'm sure this is something wrong on my end.

Collaborator

mjtko commented Sep 26, 2012

@troynt - thanks! We'll give this a try and get back to you.

andi added a commit that referenced this pull request Nov 26, 2012

Merge pull request #109 from troynt/master
Subpath shouldn't match partial URL segments. e.g. /resources/1 vs /resources_group/1

@andi andi merged commit 79ea081 into codeplant:master Nov 26, 2012

Collaborator

andi commented Nov 26, 2012

your spec is ok, all green :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment