Add proposal for default-constructible buffers #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default constructible buffers would be a useful addition for generic code. This proposal adds a zero-argument constructor and functions for determining whether or not a buffer is usable.
AerialMantis
approved these changes
Sep 4, 2019
Contributor
AerialMantis
left a comment
AerialMantis
left a comment
There was a problem hiding this comment.
Looks great, thanks! Just some minor comments.
* Add hopefully nonconflicting proposal number * Clarify what it means to use a default buffer and its functions... * ...and therefore add Gordon as a contributor :) * Add suggested operator clarification
Member
Author
|
@AerialMantis I've added some more words that hopefully clarify what default-constructed buffers should do when various of their functions are called. Thanks for the feedback! |
Ruyk
approved these changes
Sep 22, 2019
Ruyk
left a comment
Ruyk
left a comment
There was a problem hiding this comment.
I have some minor comments, but can be addressed in a separate MR.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default constructible buffers would be a useful addition for generic
code. This proposal adds a zero-argument constructor and functions
for determining whether or not a buffer is usable.