You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now the filtering model depends on an active TableScreen in order to work properly. This is a very tight coupling that might not be needed and disallows a filter model to be instantiated without a functional TableScreen.
What might be better is that each model can decide whether is being filtered or not based on the input it gets (from either a request or by a setter). In the first version, we could simply work by asking the $_GET parameters, but it would be even better to inject a Request object with the model to work with.
The methods involved now are:
get_requested_filter_values
get_requested_filter_value
get_request_var (to a lesser extend)
get_request_var_column (seems scopecreep to me, the model could do this?)
The text was updated successfully, but these errors were encountered:
Right now the filtering model depends on an active TableScreen in order to work properly. This is a very tight coupling that might not be needed and disallows a filter model to be instantiated without a functional TableScreen.
What might be better is that each model can decide whether is being filtered or not based on the input it gets (from either a request or by a setter). In the first version, we could simply work by asking the $_GET parameters, but it would be even better to inject a Request object with the model to work with.
The methods involved now are:
get_requested_filter_values
get_requested_filter_value
get_request_var (to a lesser extend)
get_request_var_column (seems scopecreep to me, the model could do this?)
The text was updated successfully, but these errors were encountered: