From a10db0bc6c47dfda8746107edfe10ed5c4d5b4df Mon Sep 17 00:00:00 2001
From: Ammar <ammar+ai@ammar.io>
Date: Thu, 23 Oct 2025 11:10:09 -0500
Subject: [PATCH 1/2] =?UTF-8?q?=F0=9F=A4=96=20Re-apply=20PR=20#382:=20Move?=
 =?UTF-8?q?=20Files=20Changed=20to=20top=20and=20remove=20stickiness?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The original PR #382 was accidentally lost during the Tailwind v4
migration (commit 7e7d5c71b79). This commit re-applies those changes
to the current Tailwind-based codebase.

Changes:
- Search bar moved outside scrollable area (always visible at top)
- Created single scrollable container for file tree + hunks
- File tree now at top in all viewports (not side-by-side)
- File tree no longer sticky - scrolls away naturally with content

Layout:
- Search bar: Fixed at top
- ScrollableContent: Single overflow-y-auto container
- FileTree: First child, sizes to content (flex-[0_0_auto])
- Hunks: Below file tree, sizes to content

Fixes: File tree remaining visible when scrolling through hunks
---
 .../RightSidebar/CodeReview/ReviewPanel.tsx   | 147 +++++++++---------
 1 file changed, 75 insertions(+), 72 deletions(-)

diff --git a/src/components/RightSidebar/CodeReview/ReviewPanel.tsx b/src/components/RightSidebar/CodeReview/ReviewPanel.tsx
index 78203cd30..2b1357130 100644
--- a/src/components/RightSidebar/CodeReview/ReviewPanel.tsx
+++ b/src/components/RightSidebar/CodeReview/ReviewPanel.tsx
@@ -555,68 +555,85 @@ export const ReviewPanel: React.FC<ReviewPanelProps> = ({
           Loading diff...
         </div>
       ) : (
-        <div className="flex min-h-0 flex-1 flex-row overflow-hidden @[800px]:flex-col">
-          <div className="order-1 flex min-h-0 min-w-0 flex-1 flex-col overflow-hidden">
-            {truncationWarning && (
-              <div className="bg-warning/10 border-warning/30 text-warning mx-3 my-3 flex items-center gap-1.5 rounded border px-3 py-1.5 text-[10px] leading-[1.3] before:text-xs before:content-['⚠️']">
-                {truncationWarning}
-              </div>
-            )}
+        <div className="flex min-h-0 flex-1 flex-col overflow-hidden">
+          {truncationWarning && (
+            <div className="bg-warning/10 border-warning/30 text-warning mx-3 my-3 flex items-center gap-1.5 rounded border px-3 py-1.5 text-[10px] leading-[1.3] before:text-xs before:content-['⚠️']">
+              {truncationWarning}
+            </div>
+          )}
+
+          {/* Search bar - always visible at top, not sticky */}
+          <div className="border-border-light bg-separator border-b px-3 py-2">
+            <div className="border-border-light bg-dark hover:border-border-gray focus-within:border-accent focus-within:hover:border-accent flex items-stretch overflow-hidden rounded border transition-[border-color] duration-150">
+              <input
+                ref={searchInputRef}
+                type="text"
+                placeholder={`Search in files and hunks... (${formatKeybind(KEYBINDS.FOCUS_REVIEW_SEARCH)})`}
+                value={searchState.input}
+                onChange={(e) => setSearchState({ ...searchState, input: e.target.value })}
+                className="text-foreground placeholder:text-dim focus:bg-separator flex h-full flex-1 items-center border-none bg-transparent px-2.5 py-1.5 font-sans text-xs leading-[1.4] outline-none"
+              />
+              <TooltipWrapper inline>
+                <button
+                  className={cn(
+                    "py-1.5 px-2.5 border-none border-l border-light text-[11px] font-monospace font-semibold leading-[1.4] cursor-pointer outline-none transition-all duration-150 whitespace-nowrap flex items-center h-full",
+                    searchState.useRegex
+                      ? "bg-review-bg-blue text-accent-light shadow-[inset_0_0_0_1px_rgba(77,184,255,0.4)] hover:bg-review-bg-info hover:text-accent-light"
+                      : "bg-transparent text-subtle hover:bg-separator hover:text-foreground",
+                    "active:translate-y-px"
+                  )}
+                  onClick={() =>
+                    setSearchState({ ...searchState, useRegex: !searchState.useRegex })
+                  }
+                >
+                  .*
+                </button>
+                <Tooltip position="bottom">
+                  {searchState.useRegex ? "Using regex search" : "Using substring search"}
+                </Tooltip>
+              </TooltipWrapper>
+              <TooltipWrapper inline>
+                <button
+                  className={cn(
+                    "py-1.5 px-2.5 border-none border-l border-light text-[11px] font-monospace font-semibold leading-[1.4] cursor-pointer outline-none transition-all duration-150 whitespace-nowrap flex items-center h-full",
+                    searchState.matchCase
+                      ? "bg-review-bg-blue text-accent-light shadow-[inset_0_0_0_1px_rgba(77,184,255,0.4)] hover:bg-review-bg-info hover:text-accent-light"
+                      : "bg-transparent text-subtle hover:bg-separator hover:text-foreground",
+                    "active:translate-y-px"
+                  )}
+                  onClick={() =>
+                    setSearchState({ ...searchState, matchCase: !searchState.matchCase })
+                  }
+                >
+                  Aa
+                </button>
+                <Tooltip position="bottom">
+                  {searchState.matchCase
+                    ? "Match case (case-sensitive)"
+                    : "Ignore case (case-insensitive)"}
+                </Tooltip>
+              </TooltipWrapper>
+            </div>
+          </div>
 
-            <div className="border-border-light bg-separator border-b px-3 py-2">
-              <div className="border-border-light bg-dark hover:border-border-gray focus-within:border-accent focus-within:hover:border-accent flex items-stretch overflow-hidden rounded border transition-[border-color] duration-150">
-                <input
-                  ref={searchInputRef}
-                  type="text"
-                  placeholder={`Search in files and hunks... (${formatKeybind(KEYBINDS.FOCUS_REVIEW_SEARCH)})`}
-                  value={searchState.input}
-                  onChange={(e) => setSearchState({ ...searchState, input: e.target.value })}
-                  className="text-foreground placeholder:text-dim focus:bg-separator flex h-full flex-1 items-center border-none bg-transparent px-2.5 py-1.5 font-sans text-xs leading-[1.4] outline-none"
+          {/* Single scrollable area containing both file tree and hunks */}
+          <div className="flex min-h-0 flex-1 flex-col overflow-y-auto">
+            {/* FileTree at the top */}
+            {(fileTree ?? isLoadingTree) && (
+              <div className="border-border-light flex w-full flex-[0_0_auto] flex-col overflow-hidden border-b">
+                <FileTree
+                  root={fileTree}
+                  selectedPath={selectedFilePath}
+                  onSelectFile={setSelectedFilePath}
+                  isLoading={isLoadingTree}
+                  getFileReadStatus={getFileReadStatus}
+                  workspaceId={workspaceId}
                 />
-                <TooltipWrapper inline>
-                  <button
-                    className={cn(
-                      "py-1.5 px-2.5 border-none border-l border-light text-[11px] font-monospace font-semibold leading-[1.4] cursor-pointer outline-none transition-all duration-150 whitespace-nowrap flex items-center h-full",
-                      searchState.useRegex
-                        ? "bg-review-bg-blue text-accent-light shadow-[inset_0_0_0_1px_rgba(77,184,255,0.4)] hover:bg-review-bg-info hover:text-accent-light"
-                        : "bg-transparent text-subtle hover:bg-separator hover:text-foreground",
-                      "active:translate-y-px"
-                    )}
-                    onClick={() =>
-                      setSearchState({ ...searchState, useRegex: !searchState.useRegex })
-                    }
-                  >
-                    .*
-                  </button>
-                  <Tooltip position="bottom">
-                    {searchState.useRegex ? "Using regex search" : "Using substring search"}
-                  </Tooltip>
-                </TooltipWrapper>
-                <TooltipWrapper inline>
-                  <button
-                    className={cn(
-                      "py-1.5 px-2.5 border-none border-l border-light text-[11px] font-monospace font-semibold leading-[1.4] cursor-pointer outline-none transition-all duration-150 whitespace-nowrap flex items-center h-full",
-                      searchState.matchCase
-                        ? "bg-review-bg-blue text-accent-light shadow-[inset_0_0_0_1px_rgba(77,184,255,0.4)] hover:bg-review-bg-info hover:text-accent-light"
-                        : "bg-transparent text-subtle hover:bg-separator hover:text-foreground",
-                      "active:translate-y-px"
-                    )}
-                    onClick={() =>
-                      setSearchState({ ...searchState, matchCase: !searchState.matchCase })
-                    }
-                  >
-                    Aa
-                  </button>
-                  <Tooltip position="bottom">
-                    {searchState.matchCase
-                      ? "Match case (case-sensitive)"
-                      : "Ignore case (case-insensitive)"}
-                  </Tooltip>
-                </TooltipWrapper>
               </div>
-            </div>
+            )}
 
-            <div className="min-h-0 flex-1 overflow-y-auto p-3">
+            {/* Hunks below the file tree */}
+            <div className="flex flex-[0_0_auto] flex-col p-3">
               {hunks.length === 0 ? (
                 <div className="text-muted flex flex-col items-center justify-start gap-3 px-6 pt-12 pb-6 text-center">
                   <div className="text-foreground text-base font-medium">No changes found</div>
@@ -691,20 +708,6 @@ export const ReviewPanel: React.FC<ReviewPanelProps> = ({
               )}
             </div>
           </div>
-
-          {/* FileTree positioning handled by CSS order property */}
-          {(fileTree ?? isLoadingTree) && (
-            <div className="border-border-light @[800px]:border-border-light order-2 flex min-h-0 w-80 shrink-0 flex-col overflow-hidden border-l @[800px]:order-0 @[800px]:h-auto @[800px]:w-full @[800px]:flex-[0_0_auto] @[800px]:border-b @[800px]:border-l-0">
-              <FileTree
-                root={fileTree}
-                selectedPath={selectedFilePath}
-                onSelectFile={setSelectedFilePath}
-                isLoading={isLoadingTree}
-                getFileReadStatus={getFileReadStatus}
-                workspaceId={workspaceId}
-              />
-            </div>
-          )}
         </div>
       )}
     </div>

From 5eef966d8a0bce42dead23b320c30bccce697768 Mon Sep 17 00:00:00 2001
From: Ammar <ammar+ai@ammar.io>
Date: Thu, 23 Oct 2025 11:11:43 -0500
Subject: [PATCH 2/2] docs: Clarify PR reuse policy to prevent unnecessary
 closures

Added explicit instruction to never close PRs without user direction.
Agents should always force-push to existing branches instead.
---
 docs/AGENTS.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/AGENTS.md b/docs/AGENTS.md
index aff8e8e22..a2b084c1d 100644
--- a/docs/AGENTS.md
+++ b/docs/AGENTS.md
@@ -24,7 +24,7 @@ This ensures transparency about AI-generated contributions.
 
 ## PR Management
 
-**Prefer to reuse existing PRs** by force-pushing to the same branch, even if the branch name becomes irrelevant. Avoid closing and recreating PRs unnecessarily - PR spam clutters the repository history.
+**Prefer to reuse existing PRs** by force-pushing to the same branch, even if the branch name becomes irrelevant. Avoid closing and recreating PRs unnecessarily - PR spam clutters the repository history. **Never close PRs without explicit user instruction.** Always force-push to the existing branch instead of creating new PRs.
 
 After submitting or updating PRs, **always check merge status**: