🤖 fix: focus Review panel when switching with Cmd+2 #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pressing Cmd+2 to switch to the Review tab, focus now immediately moves to the ReviewPanel, allowing j/k keyboard navigation to work right away. Previously, focus remained in the chat input, causing j/k to type text instead of navigating hunks. _Generated with `cmux`_ Change-Id: If1a80285fdc63387f4d5b4279c010eeb68a2c91e Signed-off-by: Test <test@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pressing Cmd+2 to switch to the Review tab, focus now immediately moves to the ReviewPanel, allowing j/k keyboard navigation to work right away.
Problem
Previously when pressing Cmd+2:
Solution
Simplified the keyboard shortcut handler to always trigger focus on the ReviewPanel when Cmd+2 is pressed, regardless of current tab state.
Testing
Manually verified:
Generated with
cmux