🤖 feat: add --add-project flag to cmux server #551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add idempotent --add-project <path> flag that: - Checks if project exists at specified path - Creates project if it doesn't exist - Sets launch project hint for frontend - Frontend auto-selects first workspace in project Backend changes: - Added --add-project CLI flag to main-server.ts - Added launchProjectPath tracking variable - Added getHandler() method to HttpIpcMainAdapter - Implemented initializeProject() to check/create project - Added server:getLaunchProject IPC endpoint Frontend changes: - Added server.getLaunchProject() to browser API - Added server property to IPCApi type - Added useEffect in AppLoader to check launch project - Auto-navigates to first workspace if available _Generated with `cmux`_
Reassign projectPath directly instead of creating unnecessary variable. _Generated with `cmux`_
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Validate and normalize path (expand tilde, make absolute) before comparing with existing projects and storing in launchProjectPath. This ensures ~/foo matches /home/user/foo in config and frontend can match normalized paths in workspace metadata. _Generated with `cmux`_
- Move validateProjectPath to static import - Remove unnecessary async from getLaunchProject handler - Handle error template literal types properly - Add proper type casting for projectsList - Use void for fire-and-forget initializeProject call _Generated with `cmux`_
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds idempotent
--add-project <path>flag to server mode.If project exists at path, opens it. If not, creates it then opens it.
Frontend auto-navigates to first workspace in the project if available.
Generated with
cmux